Thanks for the feedback Justin. We will fix the issues and create a new release candidate.
Lior On Thu, Jan 21, 2021 at 10:11 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) until apache-liminal-0.0.1-INCUBATING.tar.gz vs > apache-liminal-0.0.1-INCUBATING-source.tar.gz is cleared up. > > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exists however here no need for the ASF header in the > DISLAIMER file and where is says "List of known issues goes here” you > should list them > - LICENSE seems OK as no 3rd party software is included. Is this correct? > - NOTICE looks to contain too much information. There no need to mention > license information here, that should be in LICENSE. You should only have > "This product uses software developed at” where headers have been removed > with permission not because you are using 3rd party software.If something > in not included in the release and just a dependancy there no need to > mention it in NOTICE or LICENSE. > - A couple of files are missing headers e.g. [1] > - No unexpected binaries > > I’m not sure what apache-liminal-0.0.1-INCUBATING.tar.gz is vs > apache-liminal-0.0.1-INCUBATING-source.tar.gz. > apache-liminal-0.0.1-INCUBATING.tar.gz is missing LICENSE, NOTICE and > DISCLAIMER. A release must include these file. > > Thanks, > Justin > > 1. ./tests/runners/airflow/dag/test_liminal_dags.py > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
