Hi, +1 (binding)
I checked: - incubating in name. - Signatures and hashes are fine but please drop the md5 hash it’s not needed - DISCLAIMER exists (WIP type) - LICENSE needs more work (see blow) - NOTICE may need more work (if other ALv2 code is included) - No unexpected binary files - all source file have ASF headers - can't compile from source I can’t compile from source as I have a newer version of protobuf installed (3.6) and it looks like the build expects 2.5. Perhaps you should consider updating to a newer version? With your LICENSE I think you have included far too many things. You only need to mention something if it is bundled in the release you don’t have to mention licenses of all dependancies. I can see data tables and jQuery but not much else is bundled in your source release. There's also no need to have multiple copies of the ALv2 license text. Thanks, Justin --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
