Thanks Justin for the reply. About the missing license for the font, we've already investigated a bit on this, below is the conclusion. In this release I would like to leave as it is.
Based on https://www.glyphicons.com/license/ we do not need to directly > mention the licensing for those fonts. This is again backed up by the > comment at the top of the bootstrap page > https://getbootstrap.com/docs/3.3/components/ which is where our usage of > the fonts/icons comes from. Based on these links we are fine as is but > could also add a mention somewhere in our docs/licenses to the glyphicons > website. Another reference would be this PR for the retired Apache project > Falcon which also used these fonts > https://issues.apache.org/jira/browse/FALCON-2110 Thanks Saisai Justin Mclean <jus...@classsoftware.com> 于2020年1月22日周三 上午6:59写道： > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes are fine > - DISCLAIMER exists > - LICENSE is missing a license > - NOTICE incorrect states "2018 and onwards” please fix > - No unexpected binary files > - All source files have ASF headers > - unable to compile from source bu assume it my setup (on OSX) > > LICENSE is missing license for this font [1][2] > > Thanks, > Justin > > 1. > ./docs/assets/themes/apache/bootstrap/fonts/glyphicons-halflings-regular.* > 2. > ./server/src/main/resources/org/apache/livy/server/ui/static/fonts/glyphicons-halflings-regular.* > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
