Hi Justin

I noticed this too in my dev vote check too. I want to ask, considering the
source codes were tagged in 12/30/2019, the NOTICE should be right to keep
in 2019 for this release.
Am I right?

Sheng Wu 吴晟
Twitter, wusheng1108


zhangli...@apache.org <zhangli...@apache.org> 于2020年1月8日周三 上午11:21写道:

> > - NOTICE has wrong year
>
> Thank you your remind. I will fix it on dev branch soon and ensure it
> correct by next release.
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Justin Mclean <jus...@classsoftware.com> 于2020年1月8日周三 上午9:09写道:
>
> > Hi,
> >
> > +1 (binding)
> >
> > I checked:
> > - incubating in name
> > - signature and hash good
> > - DISCLAIMER exists
> > - LICENSE is OK
> > - NOTICE has wrong year
> > - No unexpended binary files
> > - all source file have ASF headers
> > - can compile from source
> >
> > Thanks,
> > Justin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>

Reply via email to