Hi, Some of us are not guys :-)
I’m -1 (binding) for three reasons: - the artefact names must include "incubating “ but this can be easily fixed and the voting doesn’t need to restarted (if this was the only issue) - but it also contains category B code [2] under the CDDL license. - and it also contains category X code [9] under the GPL license. you may want to consider using the work in progress disclaimer while you sort these issues out. [11] I checked: - incubating not in name - DISCLAIMER exists - LICENSE is missing appendix - NOTICE year needs to be updated - Source release contains category B code which is not allowed [2] - Source release contains Category X software which is not allowed. [9] - All ASF source files have ASF headers - No unexpected binary files I did a spot check on licenses in LICENSE and it look like it missing a few things: - SVGPan library 1.2 Copyright 2009-2010 Andrea Leofredd contain within [3] - This file written by Colin Plumb - Supporting functions within this file by Dean Edwards of unknown license. - Code Copyright (c) 2006-2013 Alexander Chemeris in these files [6][7] - MPEG2 transport stream Copyright (c) 2003 Fabrice Bellard in his file. [8] This is category X and can’t be included in a source release. - This file [10] is list as copyright Tencent when it actually Copyright (c) 2013, The TOFT Authors. Thanks, Justin 1. src/brpc/builtin/flamegraph_perl.cpp 2. https://www.apache.org/legal/resolved.html#weak-copyleft-licenses 3. ./src/brpc/builtin/pprof_perl.cpp 4. ./src/butil/md5.cc 5. ./src/brpc/builtin/sorttable_js.cpp 6. ./src/butil/third_party/rapidjson/msinttypes/inttypes.h 7. ./src/butil/third_party/rapidjson/msinttypes/stdint.h 8../src/brpc/ts.cpp 9. https://www.apache.org/legal/resolved.html#category-x 10. src/butil/memory/scoped_array.h 11. https://incubator.apache.org/policy/incubation.html#disclaimers --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
