Thanks Justin, these are super helpful! We will address these problems as follows, please let us know if you have additional suggestions
- NOTICE is still incorrect > We will change "2019 and onwards" to "2019". - I did notice a directory called "3rdparty/dlpack/apps/from_numpy” is this > code from numpy? > No the code demonstrate how to convert data from numpy to the dlpack format, the code is under ALv2 license as indicated by dlpack repo > - This file [2] has two copyright lines is this correct? We will fix the problem and keep on copyright file. > - This license [3] notes some exceptions to the ALv2 license, this might > be an issue and I suggest you ask on legal discuss if this is OK. I > wouldn't let this hold up a release. > The license [3] actually provides three licenses. The legacy section of the license indicate that the file is also licensed under MIT and University of Illinois/NCSA. We reported the file as MIT license as indicated in the source header. We also agree to discuss the exemption on ASF legal cma.c and cma/Makefile The file belongs to kernel module(which our code base does not depend on) but can be helpful when user builds a customized version of linux to run the VTA driver. Although the driver file itself is MIT, because linux kernel driver has a policy that open source driver has to be dual licensed to GPL, the driver declaration declared the binary module as GPL. After looking it closely we agree that this poses a potential risk, and will remove the file from the project (we will suggest the community to host a separate repo for kernel driver plugins). > 1. 3rdparty/cma//Makefile > 2. 3rdparty/compiler-rt/builtin_fp16.h > 3 ./licenses/LICENSE.builtin_fp16.txt > 4. ./3rdparty/cma/cma.c > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
