Justin, Thank you for your vote and comments. Your suggestions for the NOTICE file have already been incorporated in master going forward.
Please inspect it at https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE to see if there are any other changes that you would like to make. Lee. On Tue, Oct 1, 2019 at 6:07 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding > > I checked: > - incubating in name > - signature and hashes correct > - LICENSE is OK > - NOTICE has minor issues > - no unexpected binary files > - all source file have ASF headers > - can compile from source > > One minor thing with the NOTICE it’s not correct to say "2019 - Present”, > copyright applies when a work is published and doesn’t last forever. I’d > also (as suggested before on the last release) put the ASF copyright first. > > Also these two statement seem to possibly contradict each other: > Copyright 2018 - Present, Verizon > Copyright 2019 - Present, The Apache Software Foundation > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
