+1 I checked:
- Can compile from source - No unexpected binary files - Source files have ASF headers - incubating in name - signatures and hashes fine - LICENSE is fine Thanks, William On Wed, Aug 14, 2019 at 6:59 AM Furkan KAMACI <furkankam...@gmail.com> wrote: > Hi, > > +1 from me. > > I checked: > - Incubating in name > - Disclaimer exists > - LICENSE is fine > - No unexpected binary files > - Code compiles and tests successfully run > > Kind Regards, > Furkan KAMACI > > 13 Ağu 2019 Sal, saat 13:04 tarihinde Justin Mclean < > jus...@classsoftware.com> şunu yazdı: > > > Hi, > > > > > I was not directly involved in this, but it is my understanding that > the > > > modifications to our source NOTICE file between 0.15.0-incubating and > > this > > > version are a result of this thread on the IPMC vote, > > > > > > https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E > > . > > > which suggested that the NOTICE files should contain only what is > > strictly > > > required for the files actually contained in the bundle to which they > > > apply. > > > > Given you have soured files from all those project the minimum would be > > the project name and copyright line, I’m not seeing that. [1] > > > > > With regards to the 'lorem ipsum' text, I am unsure of how this is > > licensed > > > and somewhat surprised how hard this seems to be to find out > > > > I believe it’s either public domain or the copyright has expired > deepening > > on teh versions you use but it’s not easy to find out. It not an issue, > > just a curiosity. > > > > > I believe the wikiticker-2015-09-12-sampled.json.gz data was collected > > by Gian Merlino > > > from an IRC channel where a bot prints out all wikipedia edit activity > in > > > real-ish time. I don't know and haven't yet found out the ownership > > details > > > of the contents of that IRC channel, I will try to follow-up and > resolve > > > this as soon as I figure out how to do so. > > > > My guess is that you would need permission from the people who content is > > in that file, that’s probably going to be hard to obtain, so it may be > best > > to replace it with something else if possible. > > > > Thanks, > > Justin > > > > 1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
