Thanks for the review. I originally replied on the private list. I’ll reply again here:
> On May 31, 2019, at 12:37 PM, Dave Fisher <dave2w...@comcast.net> wrote: > > Apologies for the delay. > > -1 (binding) > > Policy violations: > The missing DISCLAIMER in the source release is a blocker. > Please move https://dist.apache.org/repos/dist/dev/tuweni to > https://dist.apache.org/repos/dist/dev/incubator/tuweni for the next > candidate. Ack. > > I checked the signatures and checksums. > I checked LICENSE and NOTICE. There can be some improvements for the binary > packages, but these are not blockers on a first release. Please report what could be improved - maybe in a different thread? > The tgz and zip versions diffs match. > > README.md should be directed towards building and not to advertising nightly > snapshots and referencing project build infrastructure. CI builds are not > what projects produce. Releases are what projects produce. CI builds are for > the project developer community and not the project user community. I have opened a thread on the dev list to discuss this further on May 17th - any chance we can discuss more there? https://lists.apache.org/thread.html/6df8364a753e225a8f7f0b7a42acb8c3bcafa79191cb46359f4643ee@%3Cdev.tuweni.apache.org%3E <https://lists.apache.org/thread.html/6df8364a753e225a8f7f0b7a42acb8c3bcafa79191cb46359f4643ee@%3Cdev.tuweni.apache.org%3E> > > My ./gradlew build fails in the javadoc with > tuweni-src-0.7.0/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java:29: > error: unknown tag: implSpe > * @implSpec https://github.com/ifdefelse/ProgPOW > ^ As I mentioned, this denotes that you are using a very old version of Java. Please report your setup and file a bug. > > RAT Check is pretty good once the eth-reference tests are excluded. I have opened a thread on the dev list to discuss if the .rat-excludes should be shipped with the source distro. Any chance you can reply there with more info? https://lists.apache.org/thread.html/5ce223348b003295a8b68a310eeee5b28a267ed1aa61689b5b43e596@%3Cdev.tuweni.apache.org%3E <https://lists.apache.org/thread.html/5ce223348b003295a8b68a310eeee5b28a267ed1aa61689b5b43e596@%3Cdev.tuweni.apache.org%3E> > > The two archives in the source release make sense as exceptions. A rewritten > README.md would explain the gradle wrapper. > > The file licenses/license-dependency.xml is very helpful. How is it generated? This file is generated by the build using the script gradle/check-licenses.gradle. > > Since Tuweni includes Crypto code the podling will need to file export > controls with the release [1] I might not get to this for a little while. Please let me know if this is a release blocker. Would you mind filing a bug? > > HTH, > Dave > > [1] https://www.apache.org/dev/crypto.html > >> On May 31, 2019, at 10:24 AM, Kenneth Knowles <k...@apache.org> wrote: >> >> I could not find the disclaimer from >> http://incubator.apache.org/guides/branding.html#disclaimers anywhere in >> the release. >> >> Kenn >> >> On Tue, May 28, 2019 at 11:47 AM Antoine Toulme <anto...@toulme.name> wrote: >> >>> Hello IPMC, >>> >>> The Apache Tuweni community has voted on and approved a proposal to >>> release Apache Tuweni (incubating) version 0.7.0. >>> >>> The voting thread can be found here: >>> >>> https://lists.apache.org/thread.html/65cc15293b9bc3598d0c3ca8ba4f7dbc402b6064372c14f0fae0d295@%3Cdev.tuweni.apache.org%3E >>> >>> Two binding +1 vote from mentors Jim Jagielski and Larry McCay carry over >>> from the dev list thread. >>> >>> We now kindly request the Incubator PMC members review and vote on this >>> incubator release. >>> >>> Tuweni is a set of libraries and other tools to aid development of >>> blockchain and other decentralized software in Java and other JVM languages. >>> >>> It includes a low-level bytes library, serialization and deserialization >>> codecs (e.g. RLP), various cryptography functions and primatives, and lots >>> of other helpful utilities. >>> The release candidates: >>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/ >>> >>> Git tag for the release: >>> https://github.com/apache/incubator-tuweni/tree/v0.7.0 >>> >>> Hash for the release tag: a8d55b7cd9196895a1b44be58cc33ef9d999c10b >>> >>> The artifacts have been signed with Key: 5E469BCB, which can be found in >>> the keys file: >>> >>> https://www.apache.org/dist/incubator/tuweni/KEYS >>> >>> The vote will be open for at least 72 hours or until the necessary number >>> of votes are reached. >>> >>> Please vote accordingly: >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> Thanks, >>> The Apache Tuweni (Incubating) Team >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
