Hi, +1 (binding)
Sorry for the delay there been a bit going on. I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - LICENSE could be improved - NOTICE is OK - no unexpected binaries - all source file have ASF headers - can compile from source Minor LICENSE issues: - For this this file [1] contains a copyright by Yuxi Evan You but is not mentioned license (although he is) - There copyrights belong to International Business Machines Corporation, Apple, Google, The Chromium Author and Dropbox but this in not mentioned in LICENSE. - LICENSE is missing license for [2], while not required it would be good to list. - LICENSE is missing license for this files [3][4][5] and they also probably incorrectly have a ASF header on them. Note all are different owners. - This is "Copyright 2017 The WeexCore Authors” I think that header needs to be replaced with an ASF one It might be a good idea to sign the artifacts with with an apache.org email address. Thanks, Justin 1. ./apache-weex-incubating-0.24.0-RC3-src/src/js-framework/dist/index.js 2. ./ios_sdk/WeexSDKTests/dependency/OCMock/* 3. ./weex_core/Source/include/wtf/Optional.h 4. ./weex_core/Source/include/wtf/Brigand.h 5. ./weex_core/Source/include/wtf/Variant.h 6. ./weex_core/Source/base/android/jni/scoped_java_ref.h --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
