I’m happy to give +1 (binding)
But definitely ran into more problems with this and more time than I
anticipated.
checked:
- name includes incubating
- DISCLAIMER exists
Signature and hashes
- LICENSE and NOTICE all good
Copyright year, url to and copy full text for license
- No unexpected binary files (except below)
- All source files have ASF headers
- Can compile form source (with issues)
I switched to another environment, found out I needed to manually pip
install configparser just to build (skipTest)
And then without skipTest it failed even earlier on rsc tests
Running org.apache.livy.rsc.TestSparkClient
Tests run: 19, Failures: 1, Errors: 3, Skipped: 0, Time elapsed: 30.948 sec
<<< FAILURE! - in org.apache.livy.rsc.TestSparkClient
testJobSubmission(org.apache.livy.rsc.TestSparkClient) Time elapsed: 0.486
sec <<< FAILURE!
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
listener.onJobStarted(
org.apache.livy.rsc.JobHandleImpl@75805562
);
-> at org.apache.livy.rsc.TestSparkClient$1.call(TestSparkClient.java:101)
And then the earlier python2 utf-8 issue.
Quite a number of binary resources in the src release, ttf, svg etc
also this looks like standard bootstrap script, does it have to be in the
src release (vs to include in binary release)?
docs/assets/themes/apache/bootstrap/css/bootstrap.css
if that's doc only there's another copy similarly at
server/src/main/resources/org/apache/livy/server/ui/static/css/bootstrap.min.css
On Thu, Mar 28, 2019 at 4:05 PM Marcelo Vanzin <van...@cloudera.com.invalid>
wrote:
> On Thu, Mar 28, 2019 at 3:57 PM Felix Cheung <felixche...@apache.org>
> wrote:
>
> > I have LANG=“en_US.UTF-8”
> > I tried a couple of things finally it passed when I use virtualenv - my
> > python is Python 3, forcing that to Python 2 passed the test.
>
>
> Hmmm, that tells me that the python 3 path in the fake shell might not be
> as unicode-safe as it seems, and that this test should also be running
> against python 3...
>
> As a separate issue, things could be enhanced so that they force use of
> "python2" when running the python 2 tests.
>
> But in the spirit of "these are not regressions, just bugs", I'd rather not
> block the release for that. (I filed a but for the ASCII thing already,
> I'll file others for the above.)
>
>
> > However, now
> > another test failed (maybe connection blocked by firewall?)
> >
>
> That seems likely, if you have a local firewall? (8998 is Livy's default
> port. Or maybe you have something running on that port and the tests should
> be trying an ephemeral one...)
>
>
> > error_msg = "Connection refused by Responses: POST
> > http://machine:8998/sessions/ doesn't match Responses Mock"
> > response = ConnectionError(u"Connection refused by Responses: POST
> > http://machine:8998/sessions/doesn't match Responses Mock",)
> >
>
>
> --
> Marcelo
>
