Hi, Thanks a lot for pointing us to issues we have currently.
Will fix it asap. > On Feb 27, 2019, at 04:26, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > Sorry but I’m also -1 (binding) as there is a number of issues here, there’s > compiled code in the release, the LICENSE and NOTICE files need some work and > the source files don’t have ASF headers. > > It would be good to talk to your mentors about how to fix these issues. This > release check list may also help you [4] as might this page [5]. > > I also notice that none of your mentors voted on this release on your dev > list, it probably a good idea to get at least one of them to check the > release before bringing it to the IPMC for voting. > > I checked: > - incubating in name > - signature and hashes fine > - DISCLAIMER exists > - LICENSE is missing a lot of info > - NOTICE incorrectly includes license information and look like it’s listing > dependancies rather than what included in the release as if it did it would > includes software that is not compatible with the ALv2 license (CCDL is > Category B) > - Compiled code exists in the source release [1][2] > - Be interesting to know the IP provenance of this file [3] > - Source files don’t have correct headers > - I probably don’t have the right set up to compile so didn’t try > > Thanks, > Justin > > 1. ./infrastructure-provisioning/src/general/files/os/toree-assembly-0.2.0.jar > 2. ./infrastructure-provisioning/src/general/files/os/toree_kernel.tar.gz > 3. ./integration-tests/examples/test_templates/deeplearning/cat_gray.jpg > 4. https://wiki.apache.org/incubator/IncubatorReleaseChecklist > 5. http://www.apache.org/dev/licensing-howto.html > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
