+1 binding, Checked the license file, the notice, the signature, the sha512 hash, all looks good; (I didn't run build as my docker is broken)
Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC Work email: shaofeng....@kyligence.io Kyligence Inc: https://kyligence.io/ Apache Kylin FAQ: https://kylin.apache.org/docs/gettingstarted/faq.html Join Kylin user mail group: user-subscr...@kylin.apache.org Join Kylin dev mail group: dev-subscr...@kylin.apache.org Li,De(BDG) <l...@baidu.com> 于2019年2月14日周四 下午5:26写道： > Thank you, Justin, we will fix the license issue in next release. > > On 2019/2/14 上午10:39， "Justin Mclean" <jus...@classsoftware.com> wrote: > > >Hi, > > > >+1 binding but LICENSE is missing a couple of licenses please fix in next > >release. > > > >Checked: > >- incubating in name > >- hashes and signatures good > >- LICENSE is missing some licenses (se below) > >- NOTICE is fine > >- No unexpected binaries in file > >- All ASF source files have ASF headers > >- On OSX so didn’t build > > > >LICENSE is missing MIT licensed Sizzle.js [1] included in jQuery and MIT > >licensed normalize.css included in bootstrap.css. > > > >Thanks. > >Justin > > > >1. ./webroot/static/jquery.js > >2. ./webroot/static/bootstrap.css > > > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >For additional commands, e-mail: general-h...@incubator.apache.org > > > >
