Hi, On Sat, Jan 26, 2019 at 9:45 AM Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > +1 binding but there a few minor issues that need looking into > > I checked: > - incubating in release name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE may have a couple of minor issue (see below) > - NOTICE good > - No unexpected binary in release > - A few minor header issues > - Can compile from source > > These files [1][2][3][4] have "Copyright 2012 The Netty Project” rather than > 2014 as mentioned in the NOTICE file.
According to Netty's notice file[1], I've update copyright to 2014. > > These files [5][6][7][8][9][10] have "Copyright 1999-2011 Alibaba Group” > which I assume is not correct as they were part of the donation? I think this > has been brought up previously. This issue has been fixed in 2.6.x, after 2.7.x branch is forked, but the changes are not updated in the 2.7.x branch. I have changed it into Apache License v2. > > It looks like that the header for “ExecutionList” has been replaced with an > incorrect one? It's mentioned in LICENSE. It also seem that the code from > ListenableFuture is no longer in the release but still mentioned in LICENSE? > Please fix this in the next release. If changes are made to any 3rd part > software in the release be sure to update LICENSE and NOTICE. ExecutionList is no longer needed anymore, so I've removed it. ExecutionList, ListenableFuture, ListenableFutureTask are all removed from NOTICE. I've summarized all the changes into one pull request here[2]. [1] https://github.com/netty/netty/blob/4.1/NOTICE.txt [2] https://github.com/apache/incubator-dubbo/pull/3382 > > Thanks, > Justin > > 1. > ./dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java > 2. ./dubbo-common/src/main/java/org/apache/dubbo/common/timer/Timeout.java > 3. ./dubbo-common/src/main/java/org/apache/dubbo/common/timer/Timer.java > 4. ./dubbo-common/src/main/java/org/apache/dubbo/common/timer/TimerTask.java > 5. ./dubbo-rpc/dubbo-rpc-rest/pom.xml > 6. ./dubbo-common/src/test/resources/log4j.xml > 7. ./dubbo-test/dubbo-test-compatibility/pom.xml > 8. ./dubbo-remoting/dubbo-remoting-netty/pom.xml > 9. ./dubbo-remoting/dubbo-remoting-zookeeper/pom.xml > 10. ./dubbo-monitor/dubbo-monitor-api/pom.xml > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > -- Best Regards！ Huxing --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
