+1 (binding) Downloaded, checked signatures, LICENSE, NOTICE, DISCLAIMER, built using JDK 8 on Linux, ran apache-rat. Checked that source tar ball matches git at 08c75b55f7f97be869049cf80a0da5347e550a3d.
In binary artifacts, checked signatures, LICENSE, NOTICE, DISCLAIMER. Julian > On Nov 30, 2018, at 3:43 PM, Felix Cheung <felixche...@apache.org> wrote: > > +1 (binding) > > a few comments below, checked: > filename > signature & hash > DISCLAIMER, LICENSE, NOTICE > build from src > no binary > src files have headers (see below) > > comments, not blocker for release IMO: > 1. > CREDITS file is a bit non-standard in an ASF release - this is generally > not included as it is already captured in git history and SGA > > 2. > https://jira.apache.org/jira/projects/CRAIL/issues/CRAIL-74 is marked as > Fixed but I don't see a change in the -bin tarball? > > 3. > licenses/ directory do not need to include those from ASF and on Apache v2 > license, eg. > apache-crail-1.1-incubating/licenses $ grep -e "Apache" * > LICENSE.commons-logging.txt: Apache License > LICENSE.commons-math3-3.1.1: Apache License > > 4. > Doc mentions Libdisni is a requirement - it might help to list the > supported/tested releases of Libdisni > > 5. > ASF header - docker/* and doc/* and conf/* can also have ASF header as > comment block - consider adding that > > > On Thu, Nov 29, 2018 at 6:50 AM Adrian Schuepbach <d...@zurich.ibm.com> > wrote: > >> Hi all >> >> Please vote to approve the release of Apache Crail 1.1-incubating (rc8). >> >> The podling dev vote thread: >> >> https://www.mail-archive.com/dev@crail.apache.org/msg00519.html >> >> The result: >> >> https://www.mail-archive.com/dev@crail.apache.org/msg00526.html >> >> Commit hash: 08c75b55f7f97be869049cf80a0da5347e550a3d >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-crail.git;a=commit;h=08c75b55f7f97be869049cf80a0da5347e550a3d >> >> >> Release files can be found at: >> https://dist.apache.org/repos/dist/dev/incubator/crail/1.1-rc8/ >> >> The Nexus Staging URL: >> https://repository.apache.org/content/repositories/orgapachecrail-1007/ >> >> Release artifacts are signed with the following key: >> https://www.apache.org/dist/incubator/crail/KEYS >> >> For information about the contents of this release, see: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-crail.git;a=blob_plain;f=HISTORY.md;hb=08c75b55f7f97be869049cf80a0da5347e550a3d >> or >> >> https://github.com/apache/incubator-crail/blob/08c75b55f7f97be869049cf80a0da5347e550a3d/HISTORY.md >> >> The vote is open for at least 72 hours and passes if a majority of at >> least 3 +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache Crail 1.1-incubating >> [ ] -1 Do not release this package because ... >> >> Thanks, >> Adrian >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
