Thanks Bertrand for your reply. I've just found it via the web interface: https://lists.apache.org/list.html?general@incubator.apache.org:lte=1M:tulach
Comments below... On 2018/11/26 10:34:34, Bertrand Delacretaz <b...@codeconsult.ch> wrote: > On Sun, Nov 18, 2018 at 5:48 AM Jaroslav Tulach> > <ja...@gmail.com> wrote:> > > ...As a result of such unison approval, I'd like to ask you to hold the> > > Incubator PMC vote to release:> > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/ > > ...> > > +1 for the release of incubating-netbeans-html4j-1.6.zip> Bertrand, thanks for your +1 vote! > with SHA256=3d8c554df95f13b1789130c2dcacf560562bcc61f159af39bed5d82e1f2ab01b> > > I haven't checked binaries or Maven artifacts.> > > SHA256 digest matches (I think the other ones should be removed),> > DISCLAIMER, LICENSE, NOTICE and DEPENDENCIES look good to me.> > > The build with "mvn clean install" didn't work, I got> > > > Running TestSuite> > > Configuring TestNG with: TestNG652Configurator> > > java.lang.Exception: Error> > > at org.netbeans.html.json.impl.OnReceiveTest.performErrorJSONCallNoHandling(OnReceiveTest.java: 64)> > > Not necessarily a blocker for the release from my point of view.> > Tested with java version "1.8.0_171 and Apache Maven 3.6.0.> This is the same behavior as reported by others and now tracked as https://issues.apache.org/jira/browse/NETBEANS-1703 It is harmless. > One thing that I noticed but do not consider a blocker, the file> > ./ko4j/src/main/resources/org/netbeans/html/ko4j/knockout-3.4.0.js> > is distributed minified which IMO doesn't match the spirit of> > releasing source code - reviewing that code is next to impossible, I'd> > prefer the actual source code to be distributed and minified during> > the build if needed.> This has also been observed by Justin and I reported: https://issues.apache.org/jira/browse/NETBEANS-1739 The file matches the official download from http://knockoutjs.com website https://github.com/knockout/knockout/releases/tag/v3.4.0 and I thought it is better to have an exact copy rather than create own minified version. I could download it during build however. Thanks for your review. -jt --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
