Hi Justin,
Just to clarify the need for build instructions. The documentation is part
of the repository: https://github.com/apache/incubator-crail/tree/master/doc
and can be generated with "make html". Is it sufficient if we point this out
in the README? We don't want to duplicate documentation unnecessarily and we
figure just including build instructions in the README would not get you far
since you still would not know how to run/deploy etc.
Thanks,
Jonas
On Sun, 4 Nov 2018 19:04:22 +1100
Justin Mclean <jus...@classsoftware.com> wrote:
Hi,
I’m +1 (binding) on releasing the source package, but -1 on the
binary. Assuming you get enough votes you could IMO just release the
source artefact.
I checked:
- incubating in name
- signatures and hashes good
- LICENSE and NOTICE fine
- DISCLAIMER exists
- no unexpected binary files
- can compile from source
Two very minor things:
- You might want to consider signing the release with an Apache
email address.
- What is contained in CREDITS is ally in NOTICE (in a slightly
different form).
- Please include build instructions in the released software and not
a link to them.
- At some point the documentation [1] should move to Apache
infrastructure
For the binary the LICENSE, NOTICE and DISCLAIMER is missing and the
LICENSE and NOTICE are also missing from META-INF in the jars. See
the release policy on this. [2]
Thanks,
Justin
1. https://incubator-crail.readthedocs.org
2.
http://www.apache.org/legal/release-policy.html#distribute-other-artifacts
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
