Hi,

Forwarding my +1 (binding)  from the dev list. IMO There’s some minor 
license/notice issues that need to be fixed for the next release, but 
congratulations on your first release.

I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE need some work (see below)
- No unexpected binary fines
- All source files have ASF headers
- Can compile from source

LICENSE is missing license info for Netty and this ALv2 file [1]. (This is 
optional but recommended.) NOTICE is missing information from Netty's NOTICE 
file.

Do we know where [1] comes from and if so does it have a NOTICE file?

Thanks,
Justin

1. 
./apache-plc4x-incubating-0.1.0/examples/google/src/main/java/org/apache/plc4x/java/examples/google/iotcore/MqttExampleOptions.java
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to