Hi folks!
Justin, thanks for talking such a deep look and catching those flaws, really
appreciated!
Here is my personal view: It's just test data, and if we can guarantee that the
test data is IP clean then it's not a problem.
I remember other ASF projects which have class files compiled with old Java
versions checked in as class files. They are used to verify backward
compatibility of our bytecode parsers (proxy logic). And of course you cannot
ever build those within the same build! Afair we also committed the orignal
Java sources with a comment about how to reproduce those.
Or in the maven-scm-providers-svn and maven-scm-providers-git we do this as
well. There we have a zip of a .svn and .git repos to verify the repo
functionality. That's perfectly fine as long as the content is cleared.
I've went through all of those zips [1] and verified them. Most contain just
extremely simple sample XSDs. The zips are on the Oracle contribution list. So
they are covered by the code drop. I think it's not a show stopper as they are
dead simple and contain no IP able content, but to have it even more polished
we might later re-package them and add an ALv2 LICENSE file to the zip files
(just to be dead sure).
The Java parts are either empty jars (funny that an Oracle project has
something cmpiled with Azul Zulu btw ;) ) or dead simple (just method signature
with empty body). So nothiing which constitutes originary IP again.
Rest looks fine, so
+1
from me (binding).
txs and LieGrue,
strub
[1]
~/tmp/delete/incubating-netbeans-java-9.0-rc1-source$>find . -name "*.zip"
./projectimport.eclipse.core/test/unit/data/myeclipselibstest.zip
./websvc.saas.codegen/test/unit/src/org/netbeans/modules/websvc/saas/codegen/JavaApplication.zip
./mercurial/test/qa-functional/data/JavaApp_repo.zip
./mercurial/test/qa-functional/data/files/pp.zip
./ide.kit/test/qa-functional/data/biglist.zip
./subversion/test/unit/data/SvnWcParserData.zip
./subversion/test/qa-functional/data/files/pp.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve12.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve13.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve11.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve10.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve14.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve15.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve8.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve9.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/performance1.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/performance2.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/cyclic_dependencies.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve4.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve5.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve7.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve6.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve2.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve3.zip
./xml.schema.model/test/unit/src/org/netbeans/modules/xml/schema/model/resources/resolve1.zip
./git/test/qa-functional/data/files/pp.zip
> Am 27.05.2018 um 10:29 schrieb Emilian Bold <emilian.b...@protonmail.ch>:
>
> Silly question but must Apache releases include test data?
>
> Is there a restriction on such minor binary files in the repository or just
> binary files in the release zip?
>
> I see no problem excluding all the tests in future NetBeans releases.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 27 May 2018 7:36 AM, Jan Lahoda <lah...@gmail.com> wrote:
>
>> On Sun, May 27, 2018 at 12:20 AM, Justin Mclean jus...@classsoftware.com
>>
>> wrote:
>>
>>> Hi,
>>>
>>>> I wonder where exactly (most) of these files come from.
>>>
>>> Sorry, many apologies, and my mistake as I looked at your last release by
>>>
>>> accident. Changing my vote to +0 (binding).
>>>
>>> I can still see the md5 hashes in the office release area [1] these should
>>>
>>> be removed (but that’s a minor issue).
>>>
>>> Re unexpected binary files it’s not open source if it contains
>>>
>>> unmodifiable code, that’s usually a class file in a jar file but that could
>>>
>>> also include things like obfuscated code or even minified JS.
>>>
>>> This RC1 for instance contains this jar [2] but as it contains no code
>>>
>>> that’s fine. But the _java.main.i in [3] is in a binary format and doesn’t
>>>
>>> seem to be compressed file.
>>
>> I think one could argue it is a compressed file[1], one just needs a
>>
>> special tool to get the uncompressed version (as one needs to get data out
>>
>> of the .zip or .tar.gz file):
>>
>> $ unzip incubating-netbeans-java-9.0-rc1-source.zip
>>
>> mercurial/test/qa-functional/data/JavaApp_repo.zip
>>
>> Archive: incubating-netbeans-java-9.0-rc1-source.zip
>>
>> inflating: mercurial/test/qa-functional/data/JavaApp_repo.zip
>>
>> $ cd mercurial/test/qa-functional/data/
>>
>> $ unzip JavaApp_repo.zip
>>
>> Archive: JavaApp_repo.zip
>>
>> creating: .hg/
>>
>> creating: .hg/store/
>>
>> creating: .hg/store/data/
>>
>> extracting: .hg/store/data/build.xml.i
>>
>> inflating: .hg/store/data/manifest.mf.i
>>
>> creating: .hg/store/data/nbproject/
>>
>> extracting: .hg/store/data/nbproject/build-impl.xml.i
>>
>> inflating: .hg/store/data/nbproject/genfiles.properties.i
>>
>> extracting: .hg/store/data/nbproject/project.properties.i
>>
>> inflating: .hg/store/data/nbproject/project.xml.i
>>
>> creating: .hg/store/data/src/
>>
>> creating: .hg/store/data/src/javaapp/
>>
>> inflating: .hg/store/data/src/javaapp/_main.java.i
>>
>> inflating: .hg/store/00manifest.i
>>
>> inflating: .hg/store/00changelog.i
>>
>> inflating: .hg/store/undo
>>
>> extracting: .hg/requires
>>
>> inflating: .hg/00changelog.i
>>
>> inflating: .hg/dirstate
>>
>> inflating: .hg/undo.dirstate
>>
>> extracting: .hgignore
>>
>> $ hg log
>>
>> changeset: 0:8df7d6dbbdba
>>
>> tag: tip
>>
>> user: Padraig OBriain padraig.obri...@sun.com
>>
>> date: Tue Jul 17 14:13:47 2007 +0100
>>
>> summary: Initial commit
>>
>> $ hg cat -r 0 src/javaapp/Main.java
>>
>> /*
>>
>> - Main.java
>> -
>> - Created on Jul 17, 2007, 2:13:19 PM
>> -
>> - To change this template, choose Tools | Templates
>> - and open the template in the editor.
>>
>> /package javaapp;/*
>>
>> -
>> - @author padraigo
>>
>> /public class Main {/*
>>
>> - @param args the command line arguments
>>
>> */
>>
>> public static void main(String[] args) {
>>
>> // TODO code application logic here
>>
>> }
>>
>> }
>>
>> (here I'd argue this file has no degree of creativity: this is simply
>> the
>>
>> new file template at that time with file name, date and author filled
>>
>> automatically by the IDE.)
>>
>> [1] or, more in generally multiple compressed files, as this can hold
>>
>> multiple revisions of the file, although there is only one revision
>> in this
>>
>> repo.
>>
>> Jan
>>
>>
>>> Thanks,
>>>
>>> Justin
>>>
>>> 1. https://dist.apache.org/repos/dist/dev/incubator/netbeans/
>>>
>>> incubating-netbeans-java/incubating-9.0-rc1-rc1/
>>>
>>> 2. ./autoupdate.services/test/unit/src/org/netbeans/api/
>>>
>>> autoupdate/data/empty.jar
>>>
>>> 3. ./mercurial/test/qa-functional/data/JavaApp_repo.zip
>>>
>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>>>
>>> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
