+1 (binding) Verified source bundle signature and hashes and disclaimer. Verified build and distribution artifact (no live testing).
Tephra release vote findings/improvements for consideration: 1) Use of md5 hashes worth removing in future releases 2) Copyright year in source and binary notice 3) I dont believe category B (for example the EPL dependencies in binary license) dependencies belong in the license (binary or otherwise). https://www.apache.org/legal/resolved.html#category-b It is my understanding those would be reflected in the notice. 4) There are a number of binary dependencies in the lib folder of the tephra distribution artifact that are not called out in the license/notice. These include ASF projects. Should review these for inclusion. The ASF projects might not need a mention but they often have NOTICE files and those usually need to be carried forward as well - ASF projects also have copyrights that might need to be carried over as well. Commons lang has an interesting line worth considering for inclusion https://github.com/apache/commons-lang/blob/master/NOTICE.txt On Tue, May 22, 2018 at 2:01 AM, Jitendra Pandey <jiten...@hortonworks.com> wrote: > +1 (binding) > Verified md5 of the source tarball. > Downloaded source, built successfully, ran a few unit tests. > > On 5/21/18, 9:02 PM, "Josh Elser" <els...@apache.org> wrote: > > +1 (binding) > > Things look good for the most part, a few things I noticed which can be > fixed next release: > > * NOTICE needs an updated copyright year > * `mvn apache-rat:check` fails on the below files > > <snip> > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Aopa.PL > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Asm.BSD > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/JLine.BSD > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Logback.EPL > apache-tephra-0.14.0-incubating/tephra-distribution/NOTICE_BINARY > </snip> > > On 5/21/18 6:51 PM, James Taylor wrote: > > Hi all, > > > > This is a call for a vote on releasing Apache Tephra 0.14.0-incubating, > > release candidate 1. This is the seventh release of Tephra. The Tephra > dev > > community has voted on and approved a proposal to release Tephra > > 0.14.0-incubating, release candidate 1. > > > > PPMC Vote Call: https://s.apache.org/jWVD > > > > PPMC Vote Result: https://s.apache.org/zwog > > > > The source tarball, including signatures, digests, etc. can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0.14.0-incubating-rc1/src > > > > The tag to be voted upon is v0.14.0-incubating: > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.git;a=shortlog;h=refs/tags/v0.14.0-incubating > > > > The release hash is e93942adae0ece286157a8f6a2e5c63b53669e03: > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.git;a=commit;h=e93942adae0ece286157a8f6a2e5c63b53669e03 > > > > The Nexus Staging URL: > > https://repository.apache.org/content/repositories/orgapachetephra-1011 > > > > Release artifacts are signed with the following key: > > http://people.apache.org/keys/committer/jamestaylor > > > > KEYS file available: > > https://dist.apache.org/repos/dist/dev/incubator/tephra/KEYS > > > > For information about the contents of this release, see: > > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0.14.0-incubating-rc1/CHANGES.txt > > > > Please vote on releasing this package as Apache Tephra 0.14.0-incubating > > > > The vote will be open for 72 hours. > > > > [ ] +1 Release this package as Apache Tephra 0.14.0-incubating > > [ ] +0 no opinion > > [ ] -1 Do not release this package because ... > > > > Thanks, > > James > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
