John, (1) The included jar file of license check tool (Rat) is for developers' convenience. Basically, the infrastructure about building, checking and releasing of the ECharts is based on Node.js, thus it is not convenient for the developers and users to find and install Java-based tool (Rat) to check or add the file license. (Most of them do not have the Maven installed, or even some of them do not have the Java environment installed, and basically, it should not be necessary). So we include the jar directly for there convenience, and also provides a Node.js based license check tool included (build/addHeader.js) providing the same functionality. But I have no idea yet what update should be added to LICENSE or NOTICE for this checking tool. Could I have some detailed suggestion or example?
(2) About wrapper The source file of the wrapper (build/rat/runrat.jar) is included in "build/rat/src/**". Providing a wrapper to run Rat is something helplessness. The Rat provides the feature of "list excluding regexp patterns in a file (say, ".rat-excludes")", but the patterns can only match the file names but not the file paths. Commonly, this kind of feature enables to match file paths, which is necessary. For example, I want to accurately exclude a file "test/lib/abcd.js", but do not want to exclude other files named "abcd.js", and this kind of files should be listed in the file ".rat-excludes" for maintenance consideration. I can not find a direct way to do it in Rat. So I have to make a wrapper to run Rat as a workaround to resolve the issue. ( Some details about why Rat does not support match file path: In the "org.apache.rat.walker.Walker#isIgnore" (v0.12), see "http://svn.apache.org/repos/asf/creadur/rat/tags/apache- rat-project-0.12-RC3/apache-rat-core/src/main/java/org/ apache/rat/walker/Walker.java", the "filter.accept(dir, name)" is called with the input of "dir" (file base dir) and "name" (file name without path). But in the implementation of the "org.apache.commons.io.filefilter.RegexFileFilter" and "org.apache.commons.io.filefilter.WildcardFileFilter" (v2.2), only "name" is used and "dir" is ignored, see "https://git1-us-west.apache.org/repos/asf?p=commons-io. git;a=blob;f=src/main/java/org/apache/commons/io/filefilter/RegexFileFilter. java;h=968b8c9df553392b01a58fc799920dfec764eb53;hb= 98f8e1a4334084c900bec1f62bdfe190dce8d5df" ) Shuang ------------------------------ Su Shuang (100pah) ------------------------------ 2018-05-17 20:40 GMT+08:00 John D. Ament <johndam...@apache.org>: > Shuang, > > Apologies for my late reply. > > Only issue I see is the inclusion of compiled code in the source release. > It's generally expected to not have class files, jars in the source > release. We have good faith on what is included, but no way to confirm. > Also, since you now include RAT in the distribution, there's no NOTICE or > LICENSE updates required? (I haven't checked). > > Is it possible for you just to provide instructions on how to run rat in > the project, rather than creating a wrapper? > > John > > On 2018/05/17 11:42:22, SHUANG SU <sushuang0...@gmail.com> wrote: > > I am pleased to be calling this vote for the release of Apache ECharts > > 4.1.0.rc3. > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > https://lists.apache.org/thread.html/67dffef28ecffd66689ac991ca027c > 0868d734629949d958e7b12dd3@%3Cdev.echarts.apache.org%3E > > > > Results thread: > > https://lists.apache.org/thread.html/3a6e627a7e07d5de0856296d44bb40 > 8e17ee6795cc74ef190a7a5d23@%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc3/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > A tagged git repository is available for review at: > > https://github.com/apache/incubator-echarts/releases/tag/4.1.0.rc3 > > > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > git;a=commit;h=f98eb21 > > > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc3/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc3/apache-echarts-4.1.0.rc3-incubating.zip > > -o apache-echarts-4.1.0.rc3-incubating.zip > > unzip apache-echarts-4.1.0.rc3-incubating.zip -d > > apache-echarts-4.1.0.rc3-incubating > /dev/null > > > > # Rebuild the project: > > cd "apache-echarts-4.1.0.rc3-incubating" && npm install && cd .. > > node "apache-echarts-4.1.0.rc3-incubating/build/build.js" --release > > # (See help: `node "apache-echarts-4.1.0.rc3-incubating/build/build.js" > > --help`) > > > > # Run Apache Rat: > > java -jar "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" | > less > > # (See help: `java -jar > > "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts 4.1.0.rc3 > > > > This vote will be open until "2018-05-20T12:33:24.955Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > > > ------------------------------ > > Su Shuang (100pah) > > ------------------------------ > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
