Hi Justin, 2018-02-06 17:53 GMT+09:00 Justin Mclean <jus...@classsoftware.com>: > Hi, > >> To clear discussion, the missing license body is specifically for >> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315 > > Again please carefully read [1] to comply you need to include a pointer to > the full text of the license not a URL. If you need to download the license > text and place that in a file in the release please do so.
I put License file of OFL 1.1 in the distribution and put link to it in the LICENSE. https://github.com/apache/incubator-hivemall/commit/446eac6703270aa00c8cb00dd115e7500faf6518 Font-awesome v4.6.3 uses SIL OFL 1.1 for it's License. https://github.com/FortAwesome/Font-Awesome/blob/v4.6.3/css/font-awesome.css#L3 I assume we do not need to put Apache LICENSE v2 file for https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L216 For other licenses, full texts of licenses are included. >>> - The NOTICE file still contains too much information [2] >> >> Made NOTICE clean and revised License headers following [1] with the >> following commit: > > I see you are still listing the copyrights in NOTICE. Again please ask your > mentors for help on what is required here. Update the NOTICE file. https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE [1] http://apache.org/legal/src-headers.html#notice says "The NOTICE file may also include copyright notices moved from source files submitted to the ASF." Tomcat states "Copyright 2014 The Netty Project" and "Copyright 2014 Twitter" following [1]. https://github.com/apache/tomcat/blob/trunk/NOTICE#L28 For our case, copyright before entering incubators are L10-13. The three copyright holders sent SGA when entering Incubator. You concern cleared? Thanks, Makoto --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
