+1 (binding) - checked sigs - LICENSES/NOTICE/DISCLAIMER look good - Headers look good - checked for the release tag in Git - offending (cat X) material got removed, but otherwise git tag matches release tarball
Thanks, Roman. P.S. Weirdly gradle.properties is set to non-release on tag -- you may want to look into that for future releases On Thu, Jan 25, 2018 at 10:59 AM, Jakob Homan <[email protected]> wrote: > +1 (binding) > - Sigs/asc look good > - NOTICE/LICENSE/DISCLAIMER look good > - Licenses look good > - Tests succeed > - Gradle binaries not included > > Good work. > -Jakob > > On 24 January 2018 at 13:01, Justin Mclean <[email protected]> wrote: >> Hi, >> >>> Hi, it's been almost 72 hours since the vote was opened. How many votes do >>> we need for this to pass? Can other folks take a look if necessary? >> >> I suggest asking your mentor who are IPMC member to vote. >> >> Thanks, >> Justin >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
