On Fri, Aug 4, 2017 at 12:10 PM Josh Elser <els...@apache.org> wrote:
> +1 (binding) > > It looks like you're missing a Copyright propagation for work by Trevor > Robinson in your NOTICE file. The license headers are for ASL (you are > correct to have omitted this from LICENSE), but I believe you still need > to propagate the copyright notice to your NOTICE in the src release for > the "com/scurrilous/circe" work you include in src-form. > Good catch. Initially we had it mentioned in NOTICE but then it got lost when moving other parts into the LICENSE file. I have created a PR to fix it https://github.com/apache/incubator-pulsar/pull/641 > Your RAT exclusions are pretty broad (some, matching things you aren't > even bundling). It would be in your best interest to pare down this > list, ideally setting the exclusion in each Maven module, rather than in > the parent module. That's correct. I think the main reason for the large list of exclusions is to cover all files generated during the build process, in order to be able to run "rat" even in a dirty working copy. The second reason is about files which are in the git repo but that are not included in the source distribution, like website and other tools. Since we run "rat" in out CI build, it need to ignore these. About having the exclusions in each submodule, I thought that when running on the parent maven module, it will anyway check the whole tree. In any case, I agree that having the long list makes it difficult to asses whether we're missing any file, so we will try to get it to the bare minimum. Thank you, Matteo -- Matteo Merli <mme...@apache.org>
