+1 (binding)
* xsums/sigs OK
* DISCLAIMER present
* LICENSE looks good
* NOTICE file has some unnecessary stuff, IMO:
- "In addition, this product includes software dependencies. See the
accompanying LICENSE.txt for a listing of dependencies that are NOT
Apache licensed (with pointers to their licensing)" -- This does not
seem necessary to me. This is the "norm" IMO.
- "Apache HTrace includes an Apache Thrift connector to Zipkin. Zipkin
is a distributed tracing system that is Apache 2.0 Licensed. Copyright
2012 Twitter, Inc." -- First off, are these two sentences related? What
component does the Twitter copyright apply to? My hunch would be the
files beneath "htrace-zipkin/src/main/java/com/twitter/zipkin". This
could be clarified in a later release.
* Could build from source (ran into troubles with htraced, but found
BUILDING.txt to help)
* KEYS contains the signing key
* Tag/commit exists in scm
For your next release...
* That Maven 3.0.4 hard requirement is rough :). Would be nice if HTrace
could move to a modern version of Maven.
* The shaded jars need work. They bundle numerous dependencies (with
their various licenses and notice requirements) but include the default
LICENSE and NOTICE files from the Apache parent pom. For reference, I
checked the htrace-hbase jar and see that Protobuf classes are included
but their license text is not included. I'm assuming the rest of the
jars also violate policy in a similar manner.
- Josh
On 6/2/17 4:11 PM, Mike Drob wrote:
Hi IPMC,
Please consider the release of Apache HTrace 4.3.0 Incubating
Project [VOTE]:
https://lists.apache.org/thread.html/6e60ba2574a853da59c3a150f18cd9bbd52051785380a7cc837b583e@%3Cdev.htrace.apache.org%3E
Project [RESULT][VOTE]:
https://lists.apache.org/thread.html/fb2a68fcd9c80d9db4a483794112aecde486ca263384dec0bad38c34@%3Cdev.htrace.apache.org%3E
Artifacts staged at:
http://people.apache.org/~mdrob/htrace-4.3.0-incubating-rc3/
Staging maven repository at:
https://repository.apache.org/content/repositories/orgapachehtrace-1029
Source tree:
https://git-wip-us.apache.org/repos/asf?p=incubator-htrace.git;a=tree;h=2ca8767b38c83f0d2f46ce7f91373d9df69f7fb8;hb=a47398aea8d65fb544faba150beb49bb7654cb49
Please download and evaluate the release candidate.
This vote will remain open for minimum 5 days
[ ] +1 Approve the release
[ ] +0 No opinion
[ ] -1 Do not approve the release because ...
Thanks,
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
