Hi Niclas, > On May 22, 2017, at 12:05 AM, Niclas Hedhman <nic...@hedhman.org> wrote: > > Originally, the IP Clearance was intended for "block contributions" larger > than suitable for a Jira patch file, and from people outside the community. > For example, it could be code that was made at SourceForge and IP Clearance > was to make sure that the the OK/interest of the authors was recorded (via > ICLAs, IIRC). > > In this case, it seems that the author is on the PM, have an ICLA on file, > the work is part of the same commit tree, so I see no reason for the ASF to > doubt that he had the permission from the company to commit/push.
My understanding is that the code under review here was developed outside Apache and is larger than suitable for a JIRA patch. So it is precisely the situation for which IP Clearance is intended. Craig > > > Cheers > Niclas > > On Mon, May 22, 2017 at 5:47 AM, Craig Russell <apache....@gmail.com> wrote: > >> Let's all read the documentation on IP Clearance so we have a common basis >> for discussion. >> >> Craig >> >>> On May 21, 2017, at 2:46 PM, Craig Russell <apache....@gmail.com> wrote: >>> >>>> >>>> On May 21, 2017, at 2:02 PM, John D. Ament <johndam...@apache.org> >> wrote: >>>> >>>> On Sun, May 21, 2017 at 4:54 PM Craig Russell <apache....@gmail.com> >> wrote: >>>> >>>>> Hi John, >>>>> >>>>> I don't know all of the details of the code, but this is in regard to >>>>> GridGain's grant via SGA of a persistent store system which is a >>>>> substantial body of code not developed at Apache. So IMHO it is >> appropriate >>>>> for the code grant to be reviewed. >>>>> >>>>> >>>> Errr... wait a tick. We've been told a few times that IP Clearance and >> SGA >>>> are binary. You do one or the other, not both. >>> >>> Reference, please. I recall that IP Clearance is for TLPs to vet large >> donations. >>> >>> Craig >>> >>>> Specifically SGA is to >>>> allow the modification of license (from X to Apache-V2.0) whereas IP >>>> Clearance is verifying that all existing Apache-v2.0 donation is in fact >>>> properly licensed (e.g. no hidden LGPL or other inappropriate licenses). >>>> There's even a line in the SGA that puts the ownness on this to the >> donator. >>>> >>>> If GridGain has submitted an SGA then that SGA is what is used. Have >> they >>>> actually submitted an SGA as well? >>>> >>>> >>>> >>>>> I don't see any issues except it's difficult (for me, a git novice) to >>>>> figure out the exact donation. The reference is to a git repository >> that is >>>>> "194 commits ahead, 240 commits behind apache:master". Most of the >> donated >>>>> code is in “modules/pds”. >>>>> >>>>> Craig >>>>> >>>>>> On May 20, 2017, at 8:53 PM, John D. Ament <johndam...@apache.org> >>>>> wrote: >>>>>> >>>>>> The commit referenced in the IP clearance reflects some changes in a >> pom >>>>>> file. Is that the only change? >>>>>> >>>>>> In addition, the commit seems to be from Alexey Goncharuk, who is >>>>> already a >>>>>> committer from the foundation (has an ICLA) and is on the PMC for >>>>> ignite... >>>>>> so its not clear why an IP Clearance is needed. >>>>>> >>>>>> John >>>>>> >>>>>> On Sat, May 20, 2017 at 11:42 PM Denis Magda <dma...@apache.org> >> wrote: >>>>>> >>>>>>> Apache Ignite is receiving code for distributed Persistent Store. >>>>>>> >>>>>>> See: >>>>>>> >>>>> http://incubator.apache.org/ip-clearance/persistent- >> distributed-store-ignite.html >>>>>>> >>>>>>> Please vote to approve the donation. >>>>>>> >>>>>>> This is a lazy consensus majority vote, open for at least 72 hours. >>>>>>> >>>>>>> Regards, >>>>>>> Denis >>>>>>> >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------ >> --------- >>>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>>>> >>>>>>> >>>>> >>>>> Craig L Russell >>>>> c...@apache.org >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> Craig L Russell >>> Secretary, Apache Software Foundation >>> c...@apache.org http://db.apache.org/jdo >> >> Craig L Russell >> Secretary, Apache Software Foundation >> c...@apache.org http://db.apache.org/jdo >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > > > -- > Niclas Hedhman, Software Developer > http://polygene.apache.org - New Energy for Java Craig L Russell Secretary, Apache Software Foundation c...@apache.org http://db.apache.org/jdo --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org