Oh ok I see, thanks for the point. Can you delete everything in https://dist.apache.org/repos/dist/dev/incubator/airflow/ that isn't the release under vote? I'll re-review at this point.
For the distribution, is it possible for you to publish both apache-airflow and just airflow, and somehow mark the old airflow release as deprecated? either way won't block this release. John On Thu, Mar 16, 2017 at 7:45 PM Bolke de Bruin <bdbr...@gmail.com> wrote: > Hey John, > > You seem to be unpacking BETA 1, instead of RELEASE CANDIDATE 5? > > > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > > On #2, people will in general use “pip install <source>” which is a > package manager. > > Cheers > Bolke > > > > On 16 Mar 2017, at 16:38, John D. Ament <johndam...@apache.org> wrote: > > > > Bolke, > > > > 1. Where do you see the DISCLAIMER? It should be in the root, but I see > it > > no where in the archive. > > > > ~/Desktop/airflow-1.8.0b1+apache.incubating > > ☺ ls > > > > > > MANIFEST.in PKG-INFO airflow airflow.egg-info > > setup.cfg setup.py tests > > > > ~/Desktop/airflow-1.8.0b1+apache.incubating > > ☺ find . -name "DISCLAIMER" > > > > > > > > ~/Desktop/airflow-1.8.0b1+apache.incubating > > ☺ > > > > 2. Since this is a source release, is the naming of the source release > > critical for consumers? Or do you leverage some kind of package manager > > that understands it based on the archive name? Either way, the blocker > is > > the DISCLAIMER, not this. > > > > John > > > > On Thu, Mar 16, 2017 at 7:32 PM Bolke de Bruin <bdbr...@gmail.com > <mailto:bdbr...@gmail.com>> wrote: > > > >> Hi John, > >> > >> 1. I checked the tar ball and it does contain the DISCLAIMER, is it > >> expected to be somewhere else? > >> > >> 2. Is the naming a hard requirement and a blocker for this release? The > >> reason for naming it this way, it allows for upgrading from earlier > >> versions of Airflow that were managed outside Apache. Rebranding it as > you > >> are suggesting would make it a lot harder for our users and not very > >> friendly to them. > >> > >> Cheers > >> Bolke > >> > >>> On 16 Mar 2017, at 16:19, John D. Ament <johndam...@apache.org> wrote: > >>> > >>> -1, release is missing necessary DISCLAIMER file. Also to the point > that > >>> Jakob noted, the current artifact naming must be fixed (its a branding > >>> issue from my POV). It should be apache-airflow (or something like > that) > >>> not simply airflow. > >>> > >>> John > >>> > >>> On Thu, Mar 16, 2017 at 12:40 PM Bolke de Bruin <bdbr...@gmail.com > >> <mailto:bdbr...@gmail.com <mailto:bdbr...@gmail.com>>> wrote: > >>> > >>>> Hello Incubator PMC’ers, > >>>> > >>>> The Apache Airflow community has voted and approved the proposal to > >>>> release Apache Airflow 1.8.0 (incubating) based on 1.8.0 Release > >> Candidate > >>>> 5. We now kindly request the Incubator PMC members to review and vote > on > >>>> this incubator release. If the vote is successful we will rename > release > >>>> candidate 4 to final. > >>>> > >>>> Airflow is a platform to programmatically author, schedule and monitor > >>>> workflows. Use airflow to author workflows as directed acyclic graphs > >>>> (DAGs) of tasks. The airflow scheduler executes your tasks on an array > >> of > >>>> workers while following the specified dependencies. Rich command line > >>>> utilities make performing complex surgeries on DAGs a snap. The rich > >> user > >>>> interface makes it easy to visualize pipelines running in production, > >>>> monitor progress, and troubleshoot issues when needed. When workflows > >> are > >>>> defined as code, they become more maintainable, versionable, testable, > >> and > >>>> collaborative. > >>>> > >>>> The Apache Airflow-1.8.0-incubating release candidate is now available > >>>> with the following artefacts for a project vote: > >>>> > >>>> * [VOTE] Thread:* > >>>> > >>>> > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3e > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3e > > > >>>> < > >>>> > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3E > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3E > > > >> < > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3E > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3cb1833a3a-05fb-4112-b395-135caf930...@gmail.com%3E > > > >>> > >>>>> > >>>> > >>>> *[RESULT][VOTE] Thread:* > >>>> > >>>> > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > > > >> < > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > > > >>> > >>>> < > >>>> > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > > > >> < > >> > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > < > http://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201703.mbox/%3c59bc8c2b-12e2-4de3-9555-b2273660a...@gmail.com%3e > > > >>> > >>>>> > >>>> > >>>> *The release candidate(s) to be voted on is available at:* > >>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/ < > https://dist.apache.org/repos/dist/dev/incubator/airflow/> < > >> https://dist.apache.org/repos/dist/dev/incubator/airflow/ < > https://dist.apache.org/repos/dist/dev/incubator/airflow/>> < > >>>> https://dist.apache.org/repos/dist/dev/incubator/airflow/ < > https://dist.apache.org/repos/dist/dev/incubator/airflow/> < > >> https://dist.apache.org/repos/dist/dev/incubator/airflow/ < > https://dist.apache.org/repos/dist/dev/incubator/airflow/>>> or > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > > > >>> > >>>> < > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz > > > >>> > >>>>> > >>>> > >>>> *Git branch* > >>>> https://github.com/apache/incubator-airflow/tree/v1-8-stable < > https://github.com/apache/incubator-airflow/tree/v1-8-stable> < > >> https://github.com/apache/incubator-airflow/tree/v1-8-stable < > https://github.com/apache/incubator-airflow/tree/v1-8-stable>> < > >>>> https://github.com/apache/incubator-airflow/tree/v1-8-stable < > https://github.com/apache/incubator-airflow/tree/v1-8-stable> < > >> https://github.com/apache/incubator-airflow/tree/v1-8-stable < > https://github.com/apache/incubator-airflow/tree/v1-8-stable>>> or > >>>> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > > > >> < > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > > > >>> > >>>> < > >>>> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > > > >> < > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-stable > > > >>> > >>>>> > >>>> > >>>> *Git tag* > >>>> > >>>> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > > > >> < > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > > > >>> > >>>> < > >>>> > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > > > >> < > >> > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > < > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=f4760c320a29be62469799355e76efa42d0b6bb2 > > > >>> > >>>>> > >>>> > >>>> PGP signature > >>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > > > >>> > >>>> < > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.asc > > > >>> > >>>>> > >>>> > >>>> MD5/SHA Hashes: > >>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > > > >>> > >>>> < > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.md5 > > > >>> > >>>>> > >>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > > > >>> > >>>> < > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > > > >> < > >> > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > < > https://dist.apache.org/repos/dist/dev/incubator/airflow/airflow-1.8.0rc5+apache.incubating.tar.gz.sha > > > >>> > >>>>> > >>>> > >>>> *Keys to verify the signature of the release artifacts are available > >> at:* > >>>> https://dist.apache.org/repos/dist/release/incubator/airflow/ < > https://dist.apache.org/repos/dist/release/incubator/airflow/> < > >> https://dist.apache.org/repos/dist/release/incubator/airflow/ < > https://dist.apache.org/repos/dist/release/incubator/airflow/>> < > >>>> https://dist.apache.org/repos/dist/release/incubator/airflow/ < > https://dist.apache.org/repos/dist/release/incubator/airflow/> < > >> https://dist.apache.org/repos/dist/release/incubator/airflow/ < > https://dist.apache.org/repos/dist/release/incubator/airflow/>>> > >>>> > >>>> * RAT License checks* > >>>> > >>>> RAT is executed as part of the CI process (e.g. > >>>> https://travis-ci.org/apache/incubator-airflow/builds/203106493 < > https://travis-ci.org/apache/incubator-airflow/builds/203106493> < > >> https://travis-ci.org/apache/incubator-airflow/builds/203106493> < > >>>> https://travis-ci.org/apache/incubator-airflow/builds/203106493>) but > >> can > >>>> also be run manually by issuing “sh scripts/ci/check-license.sh” from > >> the > >>>> top level. > >>>> > >>>> Source code is always included, i.e. there is no binary release. > >>>> Compilation and installation will happen by standard Python practices, > >> e.g. > >>>> pip install <> or python setup.py install. > >>>> > >>>> The vote will be open for at least 72 hours or until necessary number > of > >>>> votes are reached. > >>>> > >>>> Members please be sure to indicate "(Binding)" with your vote which > will > >>>> help in tallying the vote(s). > >>>> > >>>> [ ] +1 approve > >>>> > >>>> [ ] +0 no opinion > >>>> > >>>> [ ] -1 disapprove (and reason why) > >>>> > >>>> > >>>> *Here is my +1 (non-binding)* > >>>> > >>>> Cheers, > >>>> Bolke > >
