Jakob Are you voting on Juneau or Airflow? I’m assuming Airflow here due to the remarks. Can you respond to that thread so I can respond there?
Bolke > On 23 Feb 2017, at 21:17, Jakob Homan <jgho...@gmail.com> wrote: > > * md5 and sig looks good > * Spot check on licensing looks good > * The PKG-INFO, setup.cfg, and setup.py refer to Maxime as the author > and list his email address. This is incorrect for an Apache release. > * Missing NOTICE, DISCLAIMER and LICENSE in root. I don't believe we > can let the release go out without these, but perhaps Justin can > comment as to if this is something we're letting slide on the first > release? > * There are quite a few included javascript files. Those licenses > need to be checked and possibly included in LICENSE. > > I'm ok with +1 (binding) on this if these are the type of things that > we can let slide in the first release. It's been a while since I've > voted on a release. > > On 23 February 2017 at 06:23, James Bognar <james.bog...@salesforce.com> > wrote: >> Thanks Stian, >> >> Bugs opened for the NOTICE file, port conflict issue, and failing >> testcase. I thought we shook out all the timezone-related testcase >> failures on the last release, but I'll revisit. >> >> For the copyright, isn't the normal convention "Copyright [first year], >> [last year]" with a comma? >> >> >> >> On Thu, Feb 23, 2017 at 6:35 AM, Stian Soiland-Reyes <st...@apache.org> >> wrote: >> >>> On Wed, 22 Feb 2017 12:05:26 -0500, James Bognar <jamesbog...@apache.org> >>> wrote: >>>> The Apache Juneau Incubator PPMC has voted *+3* to release Apache Juneau >>>> 6.1.0-incubating RC2. >>>> The binaries are available at: >>>> https://dist.apache.org/repos/dist/dev/incubator/juneau/ >>> binaries/juneau-6.1.0-incubating-RC2/ >>>> >>>> The release candidate to be voted over is available at: >>>> https://dist.apache.org/repos/dist/dev/incubator/juneau/ >>> source/juneau-6.1.0-incubating-RC2/ >>> >>> Hi, apologies for not having a chance to look at this earlier. >>> >>> My vote: +1 (binding) >>> >>> Checked: >>> + pgp signatures >>> + sha1 checksums >>> + mvn apache-rat:check >>> + LICENSE, NOTICE, DISCLAIMER >>> - mvn clean install FAILS - conflict with Dropbox >>> + works with -DskipTests >>> + No unexpected binaries in src (beyond PNG) >>> + maven repo matches binary distro (same sha1 on jars and zips) >>> >>> NOTICE uses format "Copyright 2016, 2017" -- this will over time get >>> verbose >>> and I would generally think a time span is sufficient (e.g. next year it >>> can be >>> 2016-2018), but this is just a stylistic choice for the podling. :) >>> >>> NOTICE says "Apache Juneau" instead of "Apache Juneau (incubating)" >>> (However there is also a DISCLAIMER) >>> >>> >>> Building on Windows fails with: >>> >>> java.net.BindException: Address already in use: bind >>> >>> Failed tests: >>> DefaultContentTypesTest.testRestMethodParsersSerializers:119 Response >>> status code was not correct. Expected: '415'. Actual: '0' >>> ErrorConditionsTest.test404and405:184 Response status code was not >>> correct. Expected: '404'. Actual: '0' >>> ErrorConditionsTest.test412:215 Response status code was not correct. >>> Expected: '412'. Actual: '0' >>> ErrorConditionsTest.testNonExistentBeanProperties:51 Response status >>> code was not correct. Expected: '400'. Actual: '0' >>> (..) >>> Tests in error: >>> AcceptCharsetTest.testCharsetOnResponse:72 » RestCall localhost:10001 >>> failed t... >>> AcceptCharsetTest.testQValues:36->check1:57 » RestCall localhost:10001 >>> failed ... >>> BeanContextPropertiesTest.testClassTransforms:32 » RestCall >>> localhost:10001 fa... >>> (..) >>> [INFO] Apache Juneau REST Tests ........................... FAILURE [04:35 >>> min] >>> >>> It turns out port 10001 is used by Dropbox: >>> >>> λ netstat -b >>> >>> Active Connections >>> >>> Proto Local Address Foreign Address State >>> TCP 127.0.0.1:10001 biggie:56458 TIME_WAIT >>> TCP 127.0.0.1:10001 biggie:56459 TIME_WAIT >>> TCP 127.0.0.1:50228 biggie:50229 ESTABLISHED >>> [Dropbox.exe] >>> >>> If I stop Dropbox, then tcsd_win32.exe (related to Trusted Platform Module) >>> binds the port 10001 insted. This seems like a popular internal port! >>> >>> Ideally the Juneau tests should try to bind the port dynamically rather >>> than be >>> hardcoded to 10001. As this is a technical issue it does not affect my >>> IPMC >>> vote. >>> >>> >>> Stopping both daemons, the rest tests now fail with a single error: >>> >>> BeanContextPropertiesTest.testClassTransforms:33 >>> expected:<d1=2001-07-04T1[5:30:45Z,d2=2001-07-05T15:30: >>> 45Z,d3=2001-07-06T15:30:45Z]> >>> but was:<d1=2001-07-04T1[6:30:45+01:00,d2=2001-07-05T16:30:45+ >>> 01:00,d3=2001-07-06T16:30:45+01:00]> >>> >>> Timezone issue? (btw, I'm in time zone London, which is Z/GMT during >>> winter >>> time, but 4th July would be during daylight saving +01) >>> >>> >>> >>> >>> Tested with: >>> >>> D:\1\juneau-6.1.0-incubating >>> λ mvn -version >>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; >>> 2015-11-10T16:41:47+00:00) >>> Maven home: C:\Program Files\apache-maven-3.3.9\bin\.. >>> Java version: 1.8.0_121, vendor: Oracle Corporation >>> Java home: C:\Program Files\Java\jdk1.8.0_121\jre >>> Default locale: en_GB, platform encoding: Cp1252 >>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos" >>> >>> -- >>> Stian Soiland-Reyes >>> http://orcid.org/0000-0001-9842-9718 >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> >> >> >> -- >> James Bognar > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
