Ok, based on the information provided I'm changing to a +1. We should figure out if glog can really be considered acceptable, but if it is confirmed as optional then its moot per the discussion in https://issues.apache.org/jira/browse/LEGAL-280
John On Fri, Feb 10, 2017 at 9:46 AM Wang Wei <wang...@comp.nus.edu.sg> wrote: > Hi all, > > We made glog an optional dependency in this ticket > https://issues.apache.org/jira/browse/SINGA-166 and the commit history is > here > > https://github.com/apache/incubator-singa/commits/master/include/singa/utils/logging.h > > I removed glog from .travis.yml in this PR https://github.com/apache/ > incubator-singa/pull/306 > <https://github.com/apache/incubator-singa/pull/306> > And it passed all unit tests https://travis-ci.org/apache/ > incubator-singa/builds/200221600 > > I think the above links can confirm that glog is an optional dependency of > Singa. > Please let us know if we need to provide other information. > > Thanks. > > Best, > Wei > > > On Fri, Feb 10, 2017 at 11:04 AM, Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > Changing my vote to be also -1 (binding) until the license / dependancy > > issue sorted, but everything else looks good. > > > > Thanks, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
