-1 at least I think there's an issue. While the source code all looks good, the resulting binary is not valid. There's no how to build doc, so I looked at your .travis.yml. It confirmed what I suspected for make, but then I started looking at your required packages.
You require glog [1], which I can't find a license for. However, glog includes [2] which is GPL, which makes glog GPL and as a result, your code. [1]: https://github.com/google/glog [2]: https://github.com/google/glog/blob/master/missing - John On Sun, Jan 29, 2017 at 8:24 PM Wang Wei <wang...@apache.org> wrote: > Hi all, > > The SINGA community has voted on and approved a proposal to release Apache > SINGA 1.1.0 (incubating). > > The vote thread is at: > http://mail-archives.apache.org/mod_mbox/singa-dev/201701.mbox/% > 3CCAJz0iLvAaEd5AgCqaWFD1M4-D_3EBh%3DUHbeZu-MRn%3DcKuQiX-Q%40mail.gmail.com > %3E > > and the result is at: > > http://mail-archives.apache.org/mod_mbox/singa-dev/201701.mbox/%3ccajz0ilspborscstawuraowwetidb4cn14ak5sgdyb8umxoj...@mail.gmail.com%3e > > We ask the IPMC to vote on this release. > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/singa/1.1.0/ > > The hashes of the artifacts are as follows: > MD5: 08 CA 31 10 4E 79 02 16 A1 D7 3F 20 2D 60 21 BB > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/dinhtta.asc > > and the signature file is: > https://dist.apache.org/repos/dist/dev/incubator/singa/1.1.0 > /apache-singa-incubating-1.1.0-RC1.tar.gz.asc > > The Github tag is at: > https://github.com/apache/incubator-singa/releases/tag/v1.1.0-rc1 > commit ID is: 59ca44a7ce38ce4f965511c805cda074d0b8e360 > > To check the license, you can use the Apache Rat tool as follows: > 1. download & decompress apache rat from http://creadur.apache.org/rat/ > download_rat.cgi > 2. run the following command under singa folder: > java -jar /PATH/TO/RAT/apache-rat-0.11.jar -E rat-excludes -d . > > rat_check > 3. check the results in file named "rat_check" > > Please check and vote on releasing this package. The vote is open for at > least 72 hours and passes if a majority of at least three +1 votes are > cast. > > [ ] +1 Release this package as Apache SINGA 1.0.0-incubating > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Best, > Wei >
