+1 (binding)

* xsums/sigs are OK
* Git-tag SHA1's match
* Can build from source
* L&N look OK in official artifacts
* DISCLAIMER is present
* KEYS file is present on dist.a.o and contains the appropriate keys.

I would raise one issue with the streams-examples artifact but I would not consider a blocker at this point.

* It appears that you have multiple jar-with-dependencies that are built by the shade plugin. Remember, that the artifacts that your source-release creates must *also* be correctly licensed. I took a glance at twitter-follow-neo4j-jar-with-dependencies.jar which only contained the template LICENSE and NOTICE files for streams-examples. While I have no exhaustively checked every dependency that you are bundling, I would find this rather remarkable if it were accurate :)

- Josh

sblackmon wrote:
Hi Incubator PMC,

The Apache Streams community has voted and approved the proposal to
release Apache Streams 0.4.1 (incubating).

We now kindly request the Incubator PMC members to review and vote on this
incubator release.

0.4.1-incubating is a maintenance release focused on code, documentation, style 
and test improvements. Several highlights include adoption of the google java 
code style and databricks scala code style, switch from JUnit to TestNG for 
integration tests, elimination of guava transitive dependency from most 
modules, and removal of non-apache hadoop dependencies from all modules.

0.4.1-incubating also contains bug fixes and additional flexibility in the 
facebook, instagram, twitter, and youtube provider modules.

Thread [VOTE] :
https://lists.apache.org/thread.html/f27488e6a5d2355651b0aeb9dd6d82891e20d802ee3c58a0cc4a6533@%3Cdev.streams.apache.org%3E

Thread [VOTE] [RESULT] :
https://lists.apache.org/thread.html/2bd0aef6ed78bdbceb222770b39d0e92e3ffbaab53c7da2d56fff6c6@%3Cdev.streams.apache.org%3E

The Release candidate to be voted upon is 0.4.1-incubating (rc1), with the 
following artifacts up for a vote:

incubator-streams-master source tag (0.4.1-incubating):
https://git-wip-us.apache.org/repos/asf?p=incubator-streams-master.git;h=8b99488333700d2ff91bf846f656df28f90ef2fc
incubator-streams source tag (0.4.1-incubating):
https://git-wip-us.apache.org/repos/asf?p=incubator-streams.git;h=0ab58845d4006ca49c935c1010e080b1aed32c8a
incubator-streams-examples source tag (0.4.1-incubating):
https://git-wip-us.apache.org/repos/asf?p=incubator-streams-examples.git;h=298d639ea0e9cae0280970a81ac992f8e2481923

Maven staging repos:
https://repository.apache.org/content/repositories/orgapachestreams-1020
https://repository.apache.org/content/repositories/orgapachestreams-1021
https://repository.apache.org/content/repositories/orgapachestreams-1022

Source releases:
https://dist.apache.org/repos/dist/dev/incubator/streams/0.4.1-incubating/streams-master-0.4.1-incubating-source-release.zip
https://dist.apache.org/repos/dist/dev/incubator/streams/0.4.1-incubating/streams-project-0.4.1-incubating-source-release.zip
https://dist.apache.org/repos/dist/dev/incubator/streams/0.4.1-incubating/streams-examples-0.4.1-incubating-source-release.zip

Checksums of streams-master-0.4.1-incubating-source-release.zip:
MD5: f34b5799f7852756ee3be6af742c8b11
SHA1: 596346b53b66d4a7878a8443c3c3a1766c325442
Checksums of streams-project-0.4.1-incubating-source-release.zip:
MD5: a5d548ee32b856da7ecdeb7c5c6de124
SHA1: d5be5990200d05f408d13e5061fcc2bed112cbda
Checksums of streams-examples-0.4.1-incubating-source-release.zip:
MD5: 55151873d89c7c1f09e6a6f5916dc2ac
SHA1: 72921be981f739a2962e9a1363115377d86d3ac8

Release artifacts are signed with the following keys:
https://people.apache.org/keys/committer/smarthi.asc
https://people.apache.org/keys/committer/sblackmon.asc

Please take the time to verify these artifacts before casting your vote.

Note that Maven 3.3.9 and JDK 1.8+ are now required, and that MAVEN_OPTS
should set the java heap to at least 2G for best results.

These repositories must be verified (mvn clean verify) in the right order:
first streams-master, then streams-project, finally streams-examples.

Note that to execute the full suite of integration tests, one must first
prepare a testing environment with docker databases and working credentials
to all providers.

Vote will be open for 72 hours.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)




---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to