Hi, +1 binding
I checked: - incubating in artefact name - signature and hash correct - DISCLAIMER exists - LICENSE and NOTICE have a couple of very minor issues - No unexpected binary files in source release - All Apache licensed file have ASF headers - Can compile from source For the LICENSE files - missing license for json2.js [1] - missing license for Font Awesome fonts (SIL OFL) [2] - probably a good idea to add open sans to LICENSE as the files are binary and it's not clear by casual inspection that they are apache 2.0 licensed [3] For the NOTICE file: - Please move json2.js and Font Awesome to LICENSE with their license text there’s no need for them to go in NOTICE. Thanks, Justin PS Isn’t it about time you graduated? 1. ./security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/json2.js 2. ./security-admin/src/main/webapp/fonts/fontawesome/* 3. ./security-admin/src/main/webapp/fonts/fontopensans/* --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
