Thank you Justin for the always throughout and good review! Filed GEOE-1791 [1] with the LICENSE issues.
About Clearspring copyright, it has been discussed as part of M2 [2] as well and here is what we said: *"*The source for > ./geode-core/src/main/java/com/gemstone/gemfire/internal/hll/* come from > the *stream-lib project. The source files state copyright Clearspring but > their NOTICE says copyright **AddThis."* The NOTICE file has the following section: stream-lib > Copyright 2016 AddThis > This product includes software developed by AddThis. > This product also includes code adapted from: > Apache Solr (http://lucene.apache.org/solr/) > Copyright 2014 The Apache Software Foundation Hope that's ok, if not please let us know how we should proceed. Thank you, [1] https://issues.apache.org/jira/browse/GEODE-1791 [2] http://mail-archives.apache.org/mod_mbox/incubator-general/201604.mbox/% 3c9aa2aea1-0398-4f16-8fb5-e7375d867...@pivotal.io%3e On Tue, Aug 16, 2016 at 7:52 AM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding > > For the source release I checked: > - names contain incubating > - signatures good > - DISCLAIMER exists > - LICENSE has a few minor issues (see below) > - NOTICE is good > - all files have apache headers (where needed) > - no unexpected binary files in release > - can compile from source > > I didn’t check the binary connivence release. > > Minor license issues, can you please fix for the next release: > - File missing header and missing in LICENSE [1]? > - LICENSE missing Sizzle.js contained within [2] > - LICENSE is missing MooTools contained within [3] > - Only one version of JQuery is mentioned in LICENSE but two versions are > bundled [4][5] > > I notice a number of files are Apache 2.0 license but have copyright lines > in the header e.g. "Copyright (C) 2011 Clearspring Technologies, Inc.” is > this correct? > > This NOTICE file year needs updating? [6] > > Thanks, > Justin > > 1. apache-geode-src-1.0.0-incubating.M3/geode-core/src/ > main/resources/com/gemstone/gemfire/admin/jmx/internal/ > doc-files/mbeans-descriptors.dtd > 2. ./geode-pulse/src/main/webapp/scripts/lib/jquery-1.7.2.js > 3. ./geode-pulse/src/main/webapp/scripts/lib/jit.js > 4. ./apache-geode-src-1.0.0-incubating.M3/geode-site/ > website/content/js/jquery-1.10.1.min.js > 5. ./apache-geode-src-1.0.0-incubating.M3/geode-web-api/ > src/main/webapp/docs/lib/jquery-1.8.0.min.js > 6. ./geode-web/src/main/webapp/META-INF/NOTICE > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- ~/William
