Thanks Justin. I have a few questions still. On Sat, Jul 30, 2016 at 10:26 PM Justin Mclean <jus...@classsoftware.com> wrote:
> Hi, > > +1 binding > > I checked: > - release name includes incubating > - signature and hashes correct > - DISCLAIMER exits > - LICENSE and NOTICE correct. Although you might want to add > “(incubating)” after the project name in NOTICE. > In order for us to add "(incubating)" with a reproducible build, we'd have to re-do this release. Is it alright if that happened on the next version, or should we re-do this one? I know you voted +1, so I think you're okay with it as-is this time around. Is this correct? > - No source files to check for Apache headers > I think the pom.xml file is technically a source file, and does have the Apache header, but it also has the <license /> section, so it might be redundant. The apache-rat-plugin does check that one or the other exists. We kept both in to be sure. > - No binary files in release > - Can “compile” without any issues > > The release needs be placed in the /dev/dist incubator area. It's also a > good idea to include the word “apache” in the release file name. > > I'm still a little confused about the location to place the files pre-release for voting. Should I understand that there is an "official" staging area to use for voting? We followed the streamlined process done in the Accumulo project, by using the Apache Nexus staging area at repository.apache.org (it's my understanding that people used to upload artifacts to people.apache.org/~user/ prior to that), relying on the fact that once the staging repository is closed, it can't be modified and has a unique identifier. We can additionally put the same artifacts in /dev/dist (what is the full location?). Does that put the files in the mirrors? If so, I'd think we'd want to avoid that until after the vote. Regarding "apache-" as a filename prefix: In order for the filename to have "apache-" in it, we'd have to add that to the Maven artifactId, which would make things pretty redundant for its maven coordinates. Either that, or we'd just rename the file after being created from the rules set forth in the ASF-wide parent POM's execution of the maven-assembly-plugin in its apache-release profile. I don't really see too many other projects doing this... to include httpd, accumulo, hadoop, thrift, and lots of others. (some do, though, like Kudu and Tomcat). We'd like to keep the build and release process as simplified and automatic as possible, taking advantage of the standards set forth in the ASF-wide Parent POM and good Maven-coordinates naming conventions. Is this "apache-" naming prefix that important? Because it would be a bit of hoop jumping to make this reproducible and automated with Maven.
