The vote has passed with three +1 binding votes, and no -1s or 0s. Binding +1s: Jakob Homan, Justin Mclean, John D. Ament
Thanks for taking the time to look at the release! Justin, I've updated the NOTICE file in the master branch and updated the footer template in the site source code. I'll update the website along with this release. The _footer.erb page has the header but it was missing a # sign on one line (now fixed) so it may have messed up the detection. The script.js file is generated by javadocs and should be excluded I think. I actually plan to remove the multiple versions of javadocs from the git repo since they are also stored in the SVN repo for the website. -Matt On Mon, Jul 25, 2016 at 5:55 PM, John D. Ament <johndam...@apache.org> wrote: > +1 as well, no additional comments beyond what Justin pointed out. > > On Thu, Jul 21, 2016 at 6:10 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - release contains incubating > > - signatures and hashes good > > - DISCLAIMER exists > > - LICENSE and NOTICE OK > > - Most files has ASF headers > > - No unexpected binaries in release > > - Can compile from source > > > > Minor issues: > > - year is wrong in NOTICE file > > - year range in site footed doesn’t match that in NOTICE [1] > > - a few files missing ASF headers e.g. [2] > > > > Thanks, > > Justin > > > > 1. ./site/source/layouts/_footer.erb > > 2. ./site/source/docs/datafu/1.3.0/script.js > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
