+1 (bindng). Conducted a review focused largely on mechanics of the source release and licensing. Findings as follows:
good - hashes check out - signature checks out - source release license/notice/3party license references look great! nicely done - full clean build w/out tests + apache-rat:check passes. As a caution might want to reconsider how broad rat exclusions are for things like txt/json files. Can be easy to miss things which should have headers. things to address in upcoming release - full clean build w/tests results in tests failures (already identified). Recommend getting all tests passing on supported platforms. I was on Java8/OSX which seems to be supported. - checkstyle results reveal that style checks are quite optional. Recommend getting to a good stable state with checkstyle so others can help keep good hygiene going forward. - following the build instructions on the wiki i was unable to create the convenience binary tar.gz. Perhaps the instructions need updating. Ideally the readme of the source release would describe the current build process as well. My interest there was to look through any resulting convenience binaries to help with licensing/notice considerations there too. things which lead toward a negative release vote - N/A On Fri, Jul 8, 2016 at 2:52 PM, Arun C Murthy <acmur...@gmail.com> wrote: > +1 (binding) > > Arun > > On Fri, Jul 8, 2016 at 2:00 PM, Alan Gates <alanfga...@gmail.com> wrote: > >> +1. >> >> I checked the LICENSE, DISCLAIMER, and NOTICE files. Checked that there >> were no binary files in the distribution (there are images, but that seems >> ok). Checked the signatures. Did a build with a fresh local maven repo >> with -DskipTests set. >> >> When I built with tests it failed with: >> Running org.apache.atlas.TestUtils >> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.171 sec >> - in org.apache.atlas.TestUtils >> >> Results : >> >> Failed tests: >> StoreBackedTypeCacheTest.testGetTraitType:146 expected:<false> but >> was:<true> >> StoreBackedTypeCacheTest.testHasTraitType:164 expected:<false> but >> was:<true> >> >> Tests run: 452, Failures: 2, Errors: 0, Skipped: 0 >> >> This isn’t enough to scuttle the release, though it’s nice when tests >> pass. I’m building on a Mac with JDK 1.8. >> >> Alan. >> >> > On Jul 6, 2016, at 00:09, Hemanth Yamijala <yhema...@gmail.com> wrote: >> > >> > Hi all, >> > >> > This is a call for a vote on the Apache Atlas 0.7-incubating release >> > (release candidate RC2). >> > >> > A vote was held on developer mailing list and it passed with 7 +1s. >> > >> > Vote thread: https://s.apache.org/Czm4 >> > Results thread: https://s.apache.org/PAeO >> > >> > The source tarball (*.tar.gz), signature (*.asc), checksum (*.md5, >> *.sha512): >> > >> https://dist.apache.org/repos/dist/dev/incubator/atlas/0.7.0-incubating-rc2/ >> > >> > The SHA512 checksum of the archive is >> > 8B923CEA 2CDD32C8 7CE9A066 38002BFA 14F666DC C56F95AF 2805D5C1 08B58F9E >> 436E3E3C >> > 61B40908 474C67E7 782E720E 1BFA3678 B8099EBC 282F64C2 C16A48C4 >> > >> > The commit id (15748e7bc5ed019a63326f201258e3a55d512d96) to be voted >> upon: >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-atlas.git;a=commit;h=15748e7bc5ed019a63326f201258e3a55d512d96 >> > >> > The tag to be voted upon: >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-atlas.git;a=log;h=refs/tags/release-0.7-rc2 >> > >> > The list of fixed issues: >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-atlas.git;a=blob;f=release-log.txt;hb=refs/heads/0.7-incubating >> > >> > Keys to verify the signature of the release artifact are available at: >> > http://www.apache.org/dist/incubator/atlas/KEYS >> > PGP release keys: >> > http://pgp.mit.edu/pks/lookup?op=vindex&search=0xA0E6F9F5D96BF0FD >> > >> > Note that this is a source only release and we are voting on the >> > source release-0.7-incubating-rc2. >> > >> > Please download, test, and try it out. >> > >> > Vote will be open for at least 72 hours till 9th July, 2016 1 AM Pacific >> time. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove (and reason why) >> > >> > Thank you! >> > >> > Regards, >> > Hemanth >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > For additional commands, e-mail: general-h...@incubator.apache.org >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
