Hi, +1 (binding) IMO license issue need to be fixed for the next release.
I checked: - file name of release contains incubating - while signature checks out, there’s no KEYS file in the list area and there seems to be no key on file for the release manager [1] However there is a KEYS file in github. - hashes good - DISCLAIMER exists - NOTICE file contain unneeded text (i.e mentions Apache v2.0 licence). There no need to generally mention Apache 2.0 licences in NOTICE [2] - LICENSE is missing a few items [3][4] - All files have Apache headers - No binary files in release - Can compile from source I suggest you also check [3][4] with legal discuss as the Project Gutenberg license is not listed in any of the Apache license categories [5] as from a casual glance [3] adds a non-commercial restriction. i.e. “NO CHARGES MAY BE MADE FOR *ANY* ACCESS TO THIS MATERIAL”. Both license are different versions and look to have different restrictions which is also different to the latest license. [6] Also it’s best to sign the release with an Apache email address rather than a Google one Thanks, Justin 1. https://people.apache.org/keys/committer/ 2. http://www.apache.org/dev/licensing-howto.html#alv2-dep 3. ./runners/spark/src/test/resources/pg1112.txt 4. ./runners/spark/src/test/resources/pg2264.txt 5. http://www.apache.org/legal/resolved.html 6. https://www.gutenberg.org/wiki/Gutenberg:The_Project_Gutenberg_License --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
