On Wed, Apr 6, 2016 at 7:21 PM, Justin Mclean <jus...@classsoftware.com> wrote:
> Hi, > > +1 binding > > I checked: > - file name contains incubating > - signature and hash good > - contains DISCLAIMER > - LICENSE and NOTICE good > - All source files have Apache headers > - No unexpected binary files in source release > - Can compile from source (on OS X it takes a while) > > Yea, our fresh builds do take quite some time since we download and build a bunch of dependencies as part of the build process. Thanks for slogging through it and glad to hear it completed successfully! > Only possible (very minor) thing I found is I think this file should be > ASF licensed not Cloudera licensed? [1] > > You're absolutely right. Sorry about that - my editor was still configured to automatically add the old header when I created a new file. Just posted a patch here for our next release: http://gerrit.cloudera.org:8080/#/c/2729/ (and also fixed my editor file templates!) > Also amusing to note that this file [2] has 13 Apache headers in it all > copyright Twitter, no other files has duplicate headers that I could find. > > :) This one we just download from the upstream distribution, so can't really take credit for this masterpiece. I'm sure the reason is that it's "built" by concatenating a bunch of separate files. > The build instructions mentioned in the readme are hosted on a non Apache > web site. In fact all URLs to the expected incubator site redirect to this > external site. I assume at some point this will be moved to Apache > infrastructure? > > Yes -- this is one of the tasks we have outstanding that we need to do in the next month (ideally before our next report, since it was called out in our previous report). -Todd > Thanks, > Justin > > 1. ./src/kudu/util/memory/overwrite.h > 2. ./www/bootstrap/js/bootstrap.js > 3. http://getkudu.io/docs/installation.html#_build_from_source > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Todd Lipcon Software Engineer, Cloudera
