Hi, +1 binding
I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exist - LICENSE and NOTICE correct - all source file have apache headers - no unexpected binary files - can compile from source The year needs updating in the NOTICE file. I also had a quick look at the binary, I’d suggest you check [1] (no need to add apache licensed software to license) and [2] (no need to duplicate the developed at line). Not 100% sure but I think there’s also no need to add extra copyright Apache lines either, if not there there’s a number of projects which are not doing that. Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps 2. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
