Thanks Jason to check these.We should add in notice/disclaim files about this(AdminLTE already be mentioned there) But this should not a block issue for release. Hi Justin, would you mind to check and vote again? Thank you very much.
Regards! Luke Han On Wed, Oct 21, 2015 at 8:29 PM -0700, "Jian Zhong" <hellowode...@gmail.com> wrote: Hi all, about the font license Kylin UI is build with AdminLTE[1] AdminLTE license here[2] AdminLTE use google webfonts, you can see it at first line here[3] due to firewall issue,some places like CHINA may not be able to access this file.so we download it to local file "webapp/app/fonts/AdminLTE-fonts.css" about the google fonts license [4] Can I use the Fonts API on any page? Yes. All the fonts on Google Fonts are licensed under open source licenses that let you use them on any website, from a private blog to a big commercial site. 1.https://github.com/almasaeed2010/AdminLTE 2.https://github.com/almasaeed2010/AdminLTE/blob/master/LICENSE 3. https://github.com/almasaeed2010/AdminLTE/blob/master/dist/css/AdminLTE.css 4.https://developers.google.com/fonts/faq?hl=en Thanks Jason On Thu, Oct 22, 2015 at 7:07 AM, Justin Mclean wrote: > Hi, > > It’s +0 (binding) from me. > > I checked: > - release name includes incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is OK, but probably missing font license > - NOTICE all good > - All source files have apache headers (a few test files and data files > don’t) > - A couple of unexpected binary files in release > - Can compile from source > > There are two binary font files, whose licensing I’m unsure of in the > source package: > ./webapp/app/fonts/ODelI1aHBYDBqgeIAH2zlPytCVloACqnDHJwh-em2k8.woff2 > (may be Source San Pro which is covered by a SIL license so that would > also need to go into > the LICENSE file or be removed) > > ./webapp/app/fonts/toadOcfmlt9b38dHJxOBGKUt5Ot5NIMarvNW-hkYWvT3rGVtsTkPsbDajuO5ueQw.woff2 > (may be Source Sans Pro Bold?) > > This issue was brought up before [1] in a previous release. > > Thanks, > Justin > > 1. > http://mail-archives.apache.org/mod_mbox/incubator-general/201505.mbox/%3c09e70cf6-7d79-4bff-9e05-58f9c0897...@classsoftware.com%3E > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
