Daniel, thank you for your checks. C# files which are missing license headers are autogenerated from corresponding Avro/Protobuf files. BSD license comes with NSubstitute library.
We could really use two more IPMC votes :-) -Mariia -----Original Message----- From: Daniel Gruno [mailto:humbed...@apache.org] Sent: Monday, October 12, 2015 1:32 AM To: general@incubator.apache.org Subject: Re: [VOTE] Release Apache REEF 0.13.0-incubating (rc1) Did the usual checks; - Sigs, hash etc checks - unpacks fine - license, notice present - Things are apache licensed :) There are a few C# files missing license headers, see https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcompliance.rocks%2fresult.html%3f23410ea9&data=01%7c01%7cmamykhai%40microsoft.com%7cff9359a232f34528e89608d2d2df8f56%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=80r6c4FQ93EmQCmDMbTM65vOHdnGQgPEZuB0yDyHKLE%3d - but that's nothing that can't be fixed. I also saw a BSD license but no BSD license headers - I'm assuming that's just a third party lib that's not as aggressively marking its files as we do. On the whole, it looks good. I have not tested whether the programs actually _work_ - I'll leave that to people who know what REEF is and does :) +1 With regards, Daniel. On 10/10/2015 04:02 AM, Mariia Mykhailova wrote: > The Apache REEF PPMC has voted to release Apache REEF > 0.13.0-incubating based on the release candidate described below. Now > it is the IPMC's turn to vote. > > The PPMC vote passed with 5 +1 votes: > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail-a > rchives.apache.org%2fmod_mbox%2fincubator-reef-dev%2f201510.mbox%2f%25 > 3CBL2PR03MB2900A370B6F6894F8E08EA8D2370%2540BL2PR03MB290.namprd03.prod > .outlook.com%253E&data=01%7c01%7cmamykhai%40microsoft.com%7cff9359a232 > f34528e89608d2d2df8f56%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=i3 > 8mLfYTJE5AgP8Aq3%2bdEh7SxS5F6dJi5fXqOspCwQQ%3d > > > The source tar ball, including signatures, digests, etc can be found at: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist. > apache.org%2frepos%2fdist%2fdev%2fincubator%2freef%2f0.13.0-incubating > -rc1%2f&data=01%7c01%7cmamykhai%40microsoft.com%7cff9359a232f34528e896 > 08d2d2df8f56%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2770HKtZBXPX > lwVJIOKozS1HGRvebcK3tUtqrcu1IJU%3d > > The Git tag is release-0.13.0-incubating-rc1 > > The Git commit ID is e1d42e8008d97714a0f7bc303dae37239a10a029 > > > Checksums of apache-reef-0.13.0-incubating-rc1.tar.gz: > > MD5: 8e0a1cd6c7e17a86abbd32366c8cccac > SHA512: > 8f542aeaf2dc3b241bdcd0d343c607355e1f09e1ca89bbc3431b0cc1f0908479511f60 > 900a91a6731051ffef8af30488eb85df567c32bc2db9d3d91014c4fed7 > > Release artifacts are signed with a key found in the KEYS file available here: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist. > apache.org%2frepos%2fdist%2frelease%2fincubator%2freef%2fKEYS&data=01% > 7c01%7cmamykhai%40microsoft.com%7cff9359a232f34528e89608d2d2df8f56%7c7 > 2f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bLoMFCrTbg1L7KHxTct86LiY1P > KnCfiY8y4qFlqb1ZU%3d > > > > Issues Resolved in the release > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > s.apache.org%2fjira%2fsecure%2fReleaseNote.jspa%3fprojectId%3d12315820 > %26version%3d12332972&data=01%7c01%7cmamykhai%40microsoft.com%7cff9359 > a232f34528e89608d2d2df8f56%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdat > a=poEWHfvnQa6XspM0pGnMl87gnsqXdX%2bge5mcDriIKJs%3d > > > The vote will be open for 72 hours. Please download the release > candidate, check the hashes/signature, build it and test it, and then > please vote: > > [ ] +1 Release this package as Apache REEF 0.13.0-incubating [ ] +0 no > opinion [ ] -1 Do not release this package because ... > > Thanks! > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org