Hi,

+1 binding 

I checked:
- source release has incubating in it’s name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE are good
- All source code contains Apache headers
- No unexpected binaries in source release

I was unable to compile from source, may be this issue [1] but most likely 
something wrong with my setup.
Error when running gradle
Could not create task of type 'AsciidoctorTask'.

Some other things you may want to consider:
- The convenience binaries are missing incubating from their name.
- Would be better to sign the artefacts with an apache.org email address
- The file LineColumnCheck.txt looks like it's source code and is missing an 
header. Is it Apache licensed or generated?

Thanks,
Justin

1. https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/112
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to