+1 (binding) Although the L&N files are a valid concern, I don't see it should be blocking this critical security fix release. However, please make sure to get it fixed the time around.
Thanks Cos On Mon, Jul 13, 2015 at 10:33AM, Cédric Champeau wrote: > Hi all! > > The Apache Groovy PPMC has successfully voted the release of Apache Groovy > 2.4.4-incubating [1], with 6 "+1" binding votes, one "+1" non binding, no > "0" votes and one "-1" vote (see the explanation below). We are now asking > the IPMC to vote it too. Since it is our first release under the Apache > Software Foundation umbrella, let me give a few more details: > > - this release is our second attempt to release Apache Groovy 2.4.4. The > first vote failed, mainly because our documentation was licensed under > Creative Commons by-sa. The issue has been mitigated with the community, we > have voted to relicense it under AL2.0 and approvals for all contributors > of the documentation have been tracked on a JIRA ticket (see below). > - since our "pre-Apache" era, all files have been modified to include the > normalized AL2.0 license headers. Files which couldn't be modified, such as > test files which must not include any header, have been excluded from Rat > checks. > - We have updated our build to use the Gradle license check plugin, then > Apache Rat plugin > - All jars have been removed from the source distribution, including those > which were used in tests (they are now generated by the build itself) > - Added the DISCLAIMER file, updated the LICENSE and NOTICE files > - Added a section on the README to indicate how to bootstrap Gradle, since > the Apache policy forbids to include the Gradle wrapper. It's worth noting > that Andrés actually missed that when he voted -1, meaning he thought the > wrapper was missing and that we couldn't build from source. > - We updated our release process for Apache (obviously), which already > required a noticeable amount of work. We have in particular worked with the > folks at JFrog to mitigate the problems we faced in automation (our > previous release process only required a single click...). > > During the vote, the following points have been raised: > > - the "gradle.properties" file doesn't contain the license header. This is > actually a glitch due to our automation process: builds are triggered from > the CI server which automates the update of the properties file. During > that process, the license header is lost. The consequence is that running > "Rat" from the source zip will fail with a warning on that file. However, > it is not critical since this file doesn't contain any IP, just version > number and VM parameters. We will fix this in the next release, by either > excluding the file from the Rat checks, or working with JFrog so that their > plugin reincludes the header file. This problem is the main reason for the > -1 vote we had from Andrés. In case of doubt, one can verify that it's > really the CI server which removed the license by checking this commit > (716b0b1bd5) which belongs to the REL_BRANCH_2_4_4 release branch. > - The "incubating" suffix ("2.4.4-incubating") is only used on the source > zip. This is *intentional*. Groovy has a long history already, and our > users woudn't understand that newer releases include "-incubating" in the > version number. So the Maven artifacts, in particular, do not include > "-incubating", which will greatly simplify upgrading and version conflict > resolution. > - Similarily, the directory that is created doesn't include "apache-" in > the file name. Some tools widely used in the community like GVM expect a > particular layout that would break if we changed that. > > To summarize: > > Vote on dev list: > http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201507.mbox/%3CCADQzvm%3DzDNCxpOua3LQ1ZNo62Aq40QZM7SJwgER5MfkArWrTeA%40mail.gmail.com%3E > Result of vote on dev list: > http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201507.mbox/%3CCADQzvmn1yEMMz_ZaCL5QqqUtQJdgd0NNcy8v7BVY8Lt4Uog0Zg%40mail.gmail.com%3E > Relicensing of the documentation tracking: > https://issues.apache.org/jira/browse/GROOVY-7470 > Vote for relicensing the docs: > http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201506.mbox/%3CCADQzvm%3DMfajQuMxoZJmpLe%2B4W22a_MDY_dC4W%2BNMWiakEEOyNg%40mail.gmail.com%3E > Result of vote for relicensing the docs: > http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201506.mbox/%3CCADQzvmkQyOEk3ofOrnTHfnvTKO5xECY87hKAGf5pD%2BuePyA8UA%40mail.gmail.com%3E > > The changelog for this release can be found here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12331941 > > Tag for the release: > https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=commit;h=716b0b1bd56eeab04e4441eecc91c2cd8bfda8b6 > < > https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=tag;h=19f70958f39f0cc5c6b4d3e9471fd297400647d2 > > > > The artifacts to be voted on are located here: > http://people.apache.org/~cchampeau/groovy/ > > Release artifacts are signed with the following keys: > http://people.apache.org/~cchampeau/groovy/KEYS > > Vote is open for at least 72 hours. Artifacts will be moved to dist as soon > as the vote passes. > > [ ] +1, release Apache Groovy 2.4.4-incubating > [ ] 0, I don't care > [ ] -1, because... > > Best regards, --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org