+1 (binding) - Verified signature and checksums - Top level LICENSE seems fine. I'm not sure NOTICE is correct. Put the concerns below. Can other IPMC members share your thoughts? - No unexpected binaries - Able to build from source
Notice says : ---- Apache SAMOA (incubating) Copyright (C) 2014-2015 Apache Software Foundation. This product includes software developed at The Apache Software Foundation (http://www.apache.org/). This product includes software developed at Yahoo! Inc. (www.yahoo.com) Copyright (C) 2013-2014 Yahoo! Inc. This product bundles MOA version 13.08 (redistributed under the Apache License v2 with consent of the copyright holders). Copyright (C) 2007 University of Waikato. Library for data stream mining. Only a small subset of the original library is bundled with Apache SAMOA. http://moa.cms.waikato.ac.nz ---- Does the above apply to source files? If yes, which sources are with copyright Yahoo! Inc ? Also MOA version only a binary dependency, if yes, i don't think its required to be part of NOTICE. Thanks Amareshwari On Mon, Jul 13, 2015 at 1:20 PM, Gianmarco De Francisci Morales < g...@apache.org> wrote: > Hi, > > We are missing one +1 vote from the incubator. > Given that there was the weekend in between, I am going to extend the vote > for one more day. > Vote closes on July 14. > > Thanks, > > -- > Gianmarco > > On 12 July 2015 at 00:38, Justin Mclean <justinmcl...@me.com> wrote: > > > Hi, > > > > +1 binding > > > > I checked: > > - signatures and hashes good > > - name contains incubating > > - DISCLAIMER exists > > - LICENSE and NOTICE correct > > - all source files have headers > > - no unexpected binaries > > - Can compile from source > > > > Minor issue: > > - There's a few files that contain double license headers: e.g. > > samoa-0.3.0-incubating/samoa-local/src/main/resources/log4j.xml > > > > Thanks, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
