Thanks for the feedback Justin!
We are updating the LICENSE file as part of this jira:
https://issues.apache.org/jira/browse/SENTRY-764 and we will spin up a new
RC once this is reviewed and committed.
Coming to your other suggestions <please see inline>
On Thu, Jun 4, 2015 at 9:27 PM, Justin Mclean <jus...@classsoftware.com>
wrote:
> Hi,
>
> -1 binding due to license issues (and involves GPL) and release is in
> wrong location.
>
> I checked:
> - incubating in artefact name
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is not correct (see below)
> - NOTICE is correct
> - no unexpected binaries in source release
> - Most files have apache headers (see below)
>
> There are several non Apache licensed bits that need to be aded to LICENSE
> or not included in the release:
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/velocity/jquery.autocomplete.js
> (dual MIT/GPL)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ar.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_bg.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_da.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_de.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_es.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fa.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fi.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_fr.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_hi.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_hu.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_it.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_nl.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_no.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_pt.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ro.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_ru.txt
> (BSD licensed)
> ./sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/lang/stopwords_sv.txt
> (BSD licensed)
>
> Please place the release in the correct place [1], note that this is a
> “MUST” and was noted as an issue for the last incubating candidate.
>
> According to my understanding of following sections in incubator release
management wiki:
- Release distribution section [1] ("Once a release has been approved by
the Incubator PMC
<http://incubator.apache.org/incubation/Roles_and_Responsibilities.html#Incubator+Project+Management+Committee+%28PMC%29>
..") and
- Release candidates section[2]("It is traditional that release managers
use their Apache home space to make available release candidates. ..")
It looks like released artifacts go into apache.org/dist and release
candidates go into personal apache spaces. Is that not true?
For the next release also consider:
> - The are several .vm and .sql files that are missing apache headers
> - Consider removing the multiple .gitignore files in the source release
>
> We are doing this as part of
https://issues.apache.org/jira/browse/SENTRY-763
> Thanks,
> Justin
>
> 1. http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
> Thanks!
[1] -
http://incubator.apache.org/guides/releasemanagement.html#release-distribution
[2] -
http://incubator.apache.org/guides/releasemanagement.html#best-practices-release-candidates
--
Sravya Tirukkovalur
