+1 (binding) - sig/md5 sum are good - tests pass - mvn installs - headers are correct (I assume for the ps* files there are technical requirements for the script metadata to come before the license?) - license and notice are correct.
-Jakob On 19 May 2015 at 16:50, Markus Weimer <mar...@weimo.de> wrote: > On 2015-05-19 16:03, Justin Mclean wrote: >> - No unexpected binary files (although there are some Microsoft >> Visual Studio files in the release - should they be there?) > > Yes. the .sln and .csproj files are the correspondence to the pom.xml in > the Maven world. Without them, you can't build the software. > > Markus > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
