Hi, +1 binding
I checked: - signatures and hashes correct - DISCLAIMER exists - NOTICE and LICENSE correct (minor issue see below) Nice effort with the LICENSE file btw, it quite complex and everything check outs. - No unexpected binary files - Can compile from source Minor/trivial issues: - Consider adding apache to source artefact names for possible extra legal protection / branding - No need for NOTICE to include PathCompiler. it's Apache licensed and has no NOTICE file so that information IMO should go in LICENSE. It would be valid legally to omit it altogether [1] but given the author is not the ASF is nice to acknowledge where it came from. Up to you what you want to do here but either way having a minimal NOTICE file is preferred. Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#alv2-dep --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
