Hi Justin, Thank you for your time.
These files are test resources to make tests work on Jenkins on a windows machine - https://issues.apache.org/jira/browse/SLIDER-201 The readme.md located below also gives a little info but I just realized that it is incomplete - https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;a=blob;f=bin /windows/hadoop-2.6.0-SNAPSHOT/readme.md;h=9e4dd5259d1c6e892005b7fa5004aba2 c0a88400;hb=a8919c847547f0f0db74d76f67f06e1d423a61d3 Is it okay if we move them to a more appropriate location like src/test/resources directory? Or should we just delete them? Please let me know. -Gour On 3/12/15, 5:26 PM, "Justin Mclean" <jus...@classsoftware.com> wrote: >HI, > >It's -1 binding from me as there are binary files (dll's and exe's!) in >the source release (in both the .zip and tar.gz). > >Was rat run over the release? It seems a little strange the release got >this far without anyone noticing that. > >Here are the offending files: > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/hadoop.dll > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/hadoop.pdb > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/hdfs.dll > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/hdfs.pdb > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/winutils.exe > apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0/bin/winutils.pdb > >apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0-SNAPSHOT/bin/hado >op.dll > >apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0-SNAPSHOT/bin/hdfs >.dll > >apache-slider-0.70.0-incubating/bin/windows/hadoop-2.6.0-SNAPSHOT/bin/winu >tils.exe > >I did check: >- signatures and hashes correct >- DISCLAIMER exists >- LICENSE and NOTICE good >- Source files have headers >- Can compile from source >- minor issues pointed out with the last release have been fixed > >So good news is everything else looks OK to me. > >Thanks, >Justin >--------------------------------------------------------------------- >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >For additional commands, e-mail: general-h...@incubator.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
