Justin,

Most likely the problem you ran into in streams-provider-twitter was caused
by jar artifacts in your local maven repo from the prior release candidate
you built.  Same thing happened to me.

I've made a note of your feedback re. MAVEN_OPTS:
https://issues.apache.org/jira/browse/STREAMS-271

The project is already tracking the NOTICE file issue:
https://issues.apache.org/jira/browse/STREAMS-270

Thanks,

Steve Blackmon
sblack...@apache.org

On Thu, Jan 29, 2015 at 11:36 PM, Justin Mclean <jus...@classsoftware.com>
wrote:

> Hi,
>
> +1 (binding)
>
> I checked:
> - signatures correct
> - incubating in source package name
> - DISCLAIMER exists
> - NOTICE and LICENSE correct
> - all source file have Apache header
> - no unexpected binary files in release
> - can compile from source
> - couldn't get all tests to pass (streams-provider-twitter failed) but
> that may be my setup. You may want to look into this.
>
> Minor issues:
> - Year wrong in NOTICE file - can you fix this for the next release please.
> - Update readme to include recommend MAVEN_OPTS so you don't run out of
> memory when compiling
>
> Thanks,
> Justin
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to