Hi, +1 (binding) if the NOTICE and LICENSE file are fixed for the next release
I checked: - signatures and md5 correct (although format of hashes file unusual) - incubating in artefact name - no unexpected binary files in source release - all source files have apache headers - LICENSE and NOTICE have minor issues (see below) - DISCLAIMER exists - Didn't try to compile as don't have Golang set up Minor LICENSE issues: While levigo is used it doesn't seem to be bundled so there's no need to add it to LICENSE. Same (I think) with kingpin, gorilla and godep. If it not bundled there's no need for it to mentioned in LICENSE. [1] Can you double check that there are bundled in the source release and if not remove their sections from LICENSE. Minor NOTICE issue: No need to have zipkin mentioned at it is Apache licensed and it's (incorrect) NOTICE file contains nothing that needs to be added here. [2] Slightly less minor NOTICE issue is that it is missing this text at the top: [3] Apache [PRODUCT_NAME] Copyright [XXXX-20XX] The Apache Software Foundation Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle 2. https://github.com/twitter/zipkin/blob/master/NOTICE 3. http://www.apache.org/dev/licensing-howto.html#simple --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
